Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return type of db-oracle testSerialized is corrected #258

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

MrWasimAbbasi
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues return type of method corrected

Copy link

what-the-diff bot commented Mar 23, 2024

PR Summary

  • Modified Return Type in Test Function
    In ConnectionTest.php, the testSerialized function has been updated so now it specifies that it doesn't return anything, termed as void. This addition improves the readability of the code and helps prevent potential errors that might occur from expecting this function to return some value.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (2211130) to head (e45ea93).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #258   +/-   ##
=========================================
  Coverage     98.02%   98.02%           
  Complexity      175      175           
=========================================
  Files            16       16           
  Lines           556      556           
=========================================
  Hits            545      545           
  Misses           11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit e1275ac into yiisoft:master Mar 25, 2024
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants