Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deprecated methods #287

Merged
merged 5 commits into from
Feb 10, 2024
Merged

Resolve deprecated methods #287

merged 5 commits into from
Feb 10, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 29, 2024

Related with

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0acbe5) 98.42% compared to head (5c49385) 98.42%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #287   +/-   ##
=========================================
  Coverage     98.42%   98.42%           
  Complexity      329      329           
=========================================
  Files            19       19           
  Lines          1015     1015           
=========================================
  Hits            999      999           
  Misses           16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Jan 29, 2024

PR Summary

  • Introduction of the array_map function
    This update marks the inclusion of the array_map function at the beginning of the script. This feature significantly streamlines our operations by allowing us to manipulate arrays in a more sophisticated and efficient manner.

  • Replacement of normalizeRowKeyCase instances
    The respective function calls have been replaced with array_map('array_change_key_case', $array) calls in four different functions. This alteration enhances our code's performance by making the processing of array keys more flexible and dynamic.

@Tigrov Tigrov added the status:code review The pull request needs review. label Jan 30, 2024
@Tigrov Tigrov merged commit 36aa01a into master Feb 10, 2024
34 of 38 checks passed
@Tigrov Tigrov deleted the deprecate-schema-methods branch February 10, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants