Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casting integer to string in AbstractCommand::getRawSql() #788

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Dec 4, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Dec 4, 2023

PR Summary

  • Bug Fix for Type Casting in AbstractCommand::getRawSql() Method
    A fix was implemented to correct an issue within the AbstractCommand::getRawSql() functionality. Previously, the conversion process from integer values to strings was causing problems.

  • Improvised Type Conversion Routine
    The process of converting integer values to the string format has been updated in the AbstractCommand::getRawSql() method. Now, the method will first validate the integer (int)$value and subsequently convert it into a string (string).

  • New Test Case in CommandProvider.php
    A new test case was added in CommandProvider.php to ensure accuracy when fetching records through a parameterized query. This test will provide further reliability and accuracy during data manipulation.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad6577d) 99.64% compared to head (6e155c9) 99.64%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #788   +/-   ##
=========================================
  Coverage     99.64%   99.64%           
  Complexity     1265     1265           
=========================================
  Files            63       63           
  Lines          3063     3063           
=========================================
  Hits           3052     3052           
  Misses           11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit 199070f into master Dec 4, 2023
170 of 171 checks passed
@vjik vjik deleted the fix-rawSql-integer branch December 4, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants