Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docker-compose and create Dockerfile #36

Merged
merged 2 commits into from
Dec 30, 2019
Merged

update docker-compose and create Dockerfile #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1ebcff
update docker-compose and create Dockerfile
rezaei121 Dec 29, 2019
7257d5f
update docker-compose
rezaei121 Dec 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.yml.local
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: '3'
services:

php:
image: yiisoftware/yii2-php:7.2-apache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use 7.4-apache?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yiisoftware/yii2-php:7.4-apache not found.
error: manifest for yiisoftware/yii2-php:7.4-apache not found: manifest unknown: manifest unknown

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rezaei121 You don't need yii2 images. See https://hub.docker.com/r/yiisoftware/yii-php/tags

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @xepozz .
@samdark I updated pull request. new commit.

image: yiisoftware/yii-php:7.4-apache
working_dir: /app
volumes:
- ./:/app
Expand Down