Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker-compose #56

Merged
merged 7 commits into from
Feb 18, 2020
Merged

Fix docker-compose #56

merged 7 commits into from
Feb 18, 2020

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Feb 18, 2020

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Tests pass? ✔️
  1. Removed alias for public directory (Changed webroot from web to public yii-docker#7)
  2. Renamed docker-compose.yml.local to docker-compose.yml
  3. Removed unnecessary ignored files in .gitignore

@xepozz xepozz requested a review from samdark February 18, 2020 06:15
@samdark samdark added the status:code review The pull request needs review. label Feb 18, 2020
@samdark samdark requested a review from a team February 18, 2020 10:18
@samdark samdark merged commit 03ec6a7 into yiisoft:master Feb 18, 2020
@samdark
Copy link
Member

samdark commented Feb 18, 2020

Thanks!

@xepozz xepozz deleted the fix_docker branch February 18, 2020 13:41
@rossaddison rossaddison mentioned this pull request Sep 27, 2021
Closed
@rossaddison rossaddison mentioned this pull request Jan 26, 2022
Closed
@rossaddison rossaddison mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmunk42 schmunk42 schmunk42 approved these changes

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xepozz @samdark @schmunk42