Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cors for swagger #590

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Add cors for swagger #590

merged 1 commit into from
Jun 21, 2023

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Jun 17, 2023

Q A
Is bugfix? ✔️
yiisoft/yii-swagger#79

@what-the-diff
Copy link

what-the-diff bot commented Jun 17, 2023

PR Summary

  • Enabled Cross-Origin Resource Sharing (CORS) for Swagger routes
    Added middleware to allow all origins to access the Swagger API documentation.
  • Updated SwaggerJson route for compatibility with CORS middleware
    Adjusted the route definition for increased compatibility, as described in the yii-swaggerexpander documentation.

@samdark
Copy link
Member

samdark commented Jun 20, 2023

Are test failures caused by this PR?

@vjik
Copy link
Member

vjik commented Jun 21, 2023

Are test failures caused by this PR?

No, same errors on master branch

@samdark samdark merged commit 45e8379 into master Jun 21, 2023
@samdark samdark deleted the cors-swagger branch June 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik approved these changes

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xepozz @samdark @vjik