Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New providers #233

Merged
merged 22 commits into from
Aug 6, 2021
Merged

New providers #233

merged 22 commits into from
Aug 6, 2021

Conversation

yiiliveext
Copy link
Contributor

@yiiliveext yiiliveext commented Aug 4, 2021

src/CompositeContainer.php Show resolved Hide resolved
src/Container.php Outdated Show resolved Hide resolved
src/Contracts/ServiceProviderInterface.php Outdated Show resolved Hide resolved
src/Contracts/ServiceProviderInterface.php Show resolved Hide resolved
src/ExtensibleService.php Show resolved Hide resolved
src/ExtensibleService.php Outdated Show resolved Hide resolved
src/ExtensibleService.php Show resolved Hide resolved
tests/Unit/ContainerTest.php Show resolved Hide resolved
tests/Unit/ContainerTest.php Show resolved Hide resolved
tests/Unit/ContainerTest.php Outdated Show resolved Hide resolved
@BoShurik
Copy link

BoShurik commented Aug 5, 2021

Probably I missed something, but at first glance looks like DeferredServiceProviderInterface:: provides can be replaced with array_keys(ServiceProviderInterface::getDefinitions())

@yiiliveext
Copy link
Contributor Author

yiiliveext commented Aug 5, 2021

Probably I missed something, but at first glance looks like DeferredServiceProviderInterface:: provides can be replaced with array_keys(ServiceProviderInterface::getDefinitions())

We need a separate interface

src/CompositeContainer.php Outdated Show resolved Hide resolved
src/CompositeContainer.php Show resolved Hide resolved
src/Container.php Outdated Show resolved Hide resolved
src/Container.php Outdated Show resolved Hide resolved
src/Contracts/ServiceProviderInterface.php Outdated Show resolved Hide resolved
src/ExtensibleService.php Outdated Show resolved Hide resolved
src/Container.php Outdated Show resolved Hide resolved
src/Container.php Outdated Show resolved Hide resolved
src/Container.php Outdated Show resolved Hide resolved
src/ExtensibleService.php Outdated Show resolved Hide resolved
@samdark samdark merged commit 8308ef6 into yiisoft:master Aug 6, 2021
@samdark
Copy link
Member

samdark commented Aug 6, 2021

Awesome! 👍

@yiiliveext yiiliveext deleted the new-providers branch August 7, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants