Debug collector #72
Debug collector #72
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
============================================
- Coverage 99.35% 90.82% -8.54%
- Complexity 64 78 +14
============================================
Files 8 10 +2
Lines 156 207 +51
============================================
+ Hits 155 188 +33
- Misses 1 19 +18 ☔ View full report in Codecov by Sentry. |
PR Summary
|
| public function collectMessage( | ||
| MessageInterface $message, | ||
| ): void { |
There was a problem hiding this comment.
| public function collectMessage( | |
| MessageInterface $message, | |
| ): void { | |
| public function collect( | |
| MessageInterface $message, | |
| MessageInterface ...$messages, | |
| ): void { |
There was a problem hiding this comment.
This signature combines two methods into one.
There was a problem hiding this comment.
Yes, but then I need to unpack and pack arguments back
| public function collectMessages( | ||
| array $messages, | ||
| ): void { | ||
| $this->messages = array_merge($this->messages, $messages); | ||
| } | ||
|
|
There was a problem hiding this comment.
| public function collectMessages( | |
| array $messages, | |
| ): void { | |
| $this->messages = array_merge($this->messages, $messages); | |
| } |
| 'htmlBody' => $message->getCharset() === 'quoted-printable' | ||
| ? quoted_printable_decode($message->getHtmlBody()) | ||
| : $message->getHtmlBody(), |
There was a problem hiding this comment.
Message keeps html body in raw format without encoding. Seems, not need make decode here.
getCharsert returns charset ("utf-8", "windows-1251", "ISO-8859-1", etc.). It's not encoding (quoted-printable, base64, etc.). Not need this decoding here.
yiisoft/yii-dev-panel#60