Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change slashes in command names to colons #166

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

viktorprogger
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues

Related to yiisoft/yii-console#182

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e60c446) 80.89% compared to head (3429ddd) 80.89%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage     80.89%   80.89%           
  Complexity      340      340           
=========================================
  Files            40       40           
  Lines           921      921           
=========================================
  Hits            745      745           
  Misses          176      176           
Impacted Files Coverage Δ
src/Command/ListenCommand.php 0.00% <ø> (ø)
src/Command/RunCommand.php 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@what-the-diff
Copy link

what-the-diff bot commented May 28, 2023

PR Summary

  • Command name updates
    The command names have been updated for better consistency and readability. They are now formatted with a colon instead of a slash (e.g., 'queue:run' instead of 'queue/run', and 'queue:listen' instead of 'queue/listen').

@viktorprogger viktorprogger requested a review from a team May 28, 2023 14:01
@viktorprogger viktorprogger self-assigned this May 28, 2023
@viktorprogger viktorprogger added the status:code review The pull request needs review. label May 28, 2023
@viktorprogger viktorprogger added this to the 1.0.0-alpha1 milestone May 28, 2023
@samdark
Copy link
Member

samdark commented May 28, 2023

Need to change it in readme and docs as well.

Copy link
Member

@xepozz xepozz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/yiisoft/yii-debug/blob/cf492910a070aced2286af0ab8f15d4e74477e11/config/params.php#L92-L94

I'd recommend to create a constant in each command and change the command name only in one file

@samdark samdark merged commit 206c3a0 into master Jun 30, 2023
@samdark samdark deleted the change-console-command-names branch June 30, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants