Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rules from items storage in favor rules container #116

Merged
merged 11 commits into from
Feb 12, 2022
Merged

Remove rules from items storage in favor rules container #116

merged 11 commits into from
Feb 12, 2022

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 5, 2022 •
edited
Loading

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ✔️
Fixed issues #107

Adopt PRs:

@vjik vjik changed the title Rule Remove rules from items storage in favor rules container Feb 5, 2022
@samdark
Copy link
Member

samdark commented Feb 10, 2022

Overall I like the approach. Let's finish it.

This was referenced Feb 12, 2022
Merged
Merged
@vjik vjik mentioned this pull request Feb 12, 2022
Merged
@vjik vjik marked this pull request as ready for review February 12, 2022 15:53
@vjik vjik added the status:code review The pull request needs review. label Feb 12, 2022
@vjik vjik requested a review from a team February 12, 2022 15:53
@samdark samdark merged commit 90a1eef into master Feb 12, 2022
@samdark samdark deleted the rule branch February 12, 2022 17:20
@samdark
Copy link
Member

samdark commented Feb 12, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vjik @samdark @StyleCIBot