Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rector and apply suggestions #130

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 8, 2023

Updates the requirements on rector/rector to permit the latest version.

Release notes

Sourced from rector/rector's releases.

Released Rector 0.16.0

New Features 🥳

  • [TypeDeclaration] Add WhileNullableToInstanceofRector (#3680)

Bugfixes 🐛

  • Fix SingleInArrayToCompareRector if array item is variadic (#3640), Thanks @​raoz!
  • [Php80] Handle crash leaveNode() returned invalid value of type integer on TokenGetAllToObjectRector (#3644)
  • [TypeDeclaration] Handle mix InlineHTML on FileWithoutNamespace (#3648)
  • Simplify PhpFilesFinder (#3649), Thanks @​staabm!
  • [Test] Rename fixture and refactor to solve random error (#3677)
  • [TypeDeclaration] Refactor UnionTypeMapper::narrowBoolType() to allow bool|int|false converted to bool|int (#3685)
  • Update phpdoc-parser to ^1.20.3 (#3691)
  • [Privatization] Skip variable assign append on ChangeReadOnlyVariableWithDefaultValueToConstantRector (#3687), Thanks @​mickeytodd!
  • [NodeManipulator] clean up multiple instanceof check on AssignManipulator (#3695)
  • [CodeQuality] Using local variable $hasChanged on NarrowUnionTypeDocRector (#3697)
  • Cache on successful file processing (#3614), Thanks @​yguedidi!
  • [CodingStyle] Skip concat on first arg on ConsistentImplodeRector (#3702), Thanks @​nerones!
  • Fix ExplicitMethodCallOverMagicGetSetRector with a protected method (#3732), Thanks @​pierredup!
  • [TypeDeclaration] Handle infinite loop on array_reverse with index on AddMethodCallBasedStrictParamTypeRector on php8+ feature (#3678)
  • [TypeDeclaration] Handle regression multiple params no longer working on AddMethodCallBasedStrictParamTypeRector (#3681)
  • [TypeDeclaration] Add do { } while support on WhileNullableToInstanceofRector (#3682)
  • [Php56][Php70][Php74] Handle infinite loop on AddDefaultValueForUndefinedVariableRector+IfToSpaceshipRector+ClosureToArrowFunctionRector (#3701)

Performance Improvements 🚀

  • [Performance] Using findFirst() for cast to (bool) so no need search all found nodes (#3642)
  • [Performance] Using cheap chekc first on UndefinedVariableResolver::shouldSkipVariable() (#3643)
  • [CodeQuality] Improve SimplifyIfElseToTernaryRector performance (#3721)
  • [Renaming] Prevent overly greed type resolving in RenamePropertyRector (#3700), Thanks @​staabm!
  • Don't calculate diffs when --no-diffs is given (#3710), Thanks @​staabm!
  • Calculate diff only once per file after refactoring (#3711), Thanks @​staabm!
  • Improve PropertyFetchAnalyzer performance (#3654), Thanks @​staabm!
  • Improve LocalMethodCallFinder performance (#3651), Thanks @​staabm!
  • Improve LocalConstantFinder performance (#3652), Thanks @​staabm!
  • Improve NodeComparator performance (#3659), Thanks @​staabm!
  • Improve ReflectionResolver performance (#3658), Thanks @​staabm!
  • Improve ParentClassMethodTypeOverrideGuard performance (#3660), Thanks @​staabm!
  • [PHPStanStaticTypeMapper] Improve UnionTypeMapper performance (#3686)
  • [PHPStanStaticTypeMapper] Improve UnionTypeMapper performance take 2 (rectorphp/rector-src@931e6e2)
  • [PHPStanStaticTypeMapper] Improve performance of UnionTypeMapper take 3 (#3690)
  • [Renaming] Improve performance of RenameFunctionRector (#3699)
  • Add e2e tests for consecutive changing runs (#3666), Thanks @​yguedidi!
  • [Renaming] Improve performance of RenamePropertyRector (#3698)

... (truncated)

Commits
  • 2125ff7 Rector 0.16.0
  • 5eeea88 Updated Rector to commit 4179a87aac262d7f38daf79f8a2f530808d1cf8e
  • e0ddc70 Updated Rector to commit d9374ddfa6c8a1ae41c1ac271d102980c6eba8f5
  • 61359ad Updated Rector to commit d9374ddfa6c8a1ae41c1ac271d102980c6eba8f5
  • 1e2a0a6 Updated Rector to commit 8b48059c347d98d191478504da236c4c2ba1e667
  • 4628b8b Updated Rector to commit 657ec2e5af81361107cafc9c842b1d9cdf4ed760
  • ab1fc21 Updated Rector to commit 09b59efbc73c7cd28672d9605b9a17b8f14d2c2a
  • 68933a6 Updated Rector to commit 67ce52f0a8d6fff37ca569deba67c5635684dde6
  • ad0c32e Updated Rector to commit 05cc9af356d08f264c0faabd6a22149c1c06da89
  • dd229e0 Updated Rector to commit 05cc9af356d08f264c0faabd6a22149c1c06da89
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@0.15.4...0.16.0)

---
updated-dependencies:
- dependency-name: rector/rector
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels May 8, 2023
@what-the-diff
Copy link

what-the-diff bot commented May 8, 2023

PR Summary

  • Update Rector version
    Upgrade the Rector version from 0.15.4 to 0.16, improving code quality and incorporating latest features.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2c9dcd1) 99.49% compared to head (870d633) 99.49%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #130   +/-   ##
=========================================
  Coverage     99.49%   99.49%           
  Complexity       85       85           
=========================================
  Files             2        2           
  Lines           198      198           
=========================================
  Hits            197      197           
  Misses            1        1           
Files Changed Coverage Δ
src/UrlMatcher.php 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik changed the title Update rector/rector requirement from ^0.15.4 to ^0.16.0 Update rector/rector requirement to ^0.17 Aug 10, 2023
@vjik vjik changed the title Update rector/rector requirement to ^0.17 Update rector and apply suggestions Aug 10, 2023
@vjik vjik merged commit 1789a39 into master Aug 10, 2023
23 checks passed
@vjik vjik deleted the dependabot/composer/rector/rector-tw-0.16.0 branch August 10, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants