Fix #46: Support static $defaultDescription property #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
samdark
commented
Aug 31, 2021
samdark
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | #46 |
samdark
added
type:enhancement
7 tasks
|
@BoShurik does it look alright to you? |
BoShurik
suggested changes
Aug 31, 2021
src/CommandLoader.php
Outdated
|
|
||
| return new LazyCommand( | ||
| $name, | ||
| [], |
There was a problem hiding this comment.
What about aliases? In Symfony they stored in default name with | separator:
protected static $defaultName = 'app:my-command|project:my-command|legacy:foo';
It may be useful while refactoring
There was a problem hiding this comment.
Added that and hidden commands. It doesn't work too well though. Aliases are displayed but commands could not be accessed using aliases.
BoShurik
approved these changes
Sep 1, 2021
vjik
approved these changes
Sep 1, 2021
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.