Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style output, add xdebug shortcut #180

Merged
merged 8 commits into from
May 28, 2023
Merged

Style output, add xdebug shortcut #180

merged 8 commits into from
May 28, 2023

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Apr 30, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues comma-separated list of tickets # fixed by the PR, if any

XDebug is installed

./yii serve --xdebug

image

./yii serve

image

XDebug is not installed / loaded

When xdebug extension is not installed / loaded

./yii serve

same for --xdebug

image

Verbose

./yii serve --xdebug -v

image

./yii serve -v

image

@xepozz xepozz requested a review from a team April 30, 2023 10:04
@what-the-diff
Copy link

what-the-diff bot commented Apr 30, 2023

PR Summary

  • Added title and link to Yii Framework website
    Included a website reference to provide more information on the Yii Framework.
  • Improved warning message for missing default router file
    Updated the warning message for better clarity when the default router file is not found.
  • Introduced table for configuration information
    A table has been added to display crucial configuration info, such as PHP version, xDebug status, and number of workers.
  • Removed redundant output for document root and routing file
    Cleaned up the output by removing unnecessary display of document root and routing file when it matches the default configuration values.
  • Added checks for command execution results after passthru() call
    Enhanced the execution process by verifying the command result after the passthru() call. This helps ensure the command's accuracy and successful completion.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need line in changelog

src/Command/Serve.php Outdated Show resolved Hide resolved
src/Command/Serve.php Outdated Show resolved Hide resolved
@samdark
Copy link
Member

samdark commented May 3, 2023

Tests should be fixed.

src/Command/Serve.php Outdated Show resolved Hide resolved
samdark and others added 3 commits May 4, 2023 13:13
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Patch coverage: 94.91% and project coverage change: +1.55 🎉

Comparison is base (7b87314) 95.30% compared to head (255701c) 96.86%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #180      +/-   ##
============================================
+ Coverage     95.30%   96.86%   +1.55%     
- Complexity       73       80       +7     
============================================
  Files             9        9              
  Lines           213      255      +42     
============================================
+ Hits            203      247      +44     
+ Misses           10        8       -2     
Impacted Files Coverage Δ
src/Command/Serve.php 96.26% <94.91%> (+5.49%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samdark samdark merged commit 90b9774 into master May 28, 2023
@samdark samdark deleted the improve branch May 28, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants