Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream output #58

Merged
merged 23 commits into from
Mar 3, 2024
Merged

Stream output #58

merged 23 commits into from
Mar 3, 2024

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Sep 10, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 10, 2023

PR Summary

  • Update to CHANGELOG.md

    • The version of the software is now moved to '2.1.0 under development'.
    • New enhancement has been included which is the support for streaming output, meaning the software can now continuously send data out rather than in chunks.
  • Modifications to SapiEmitter.php

    • A function flush() has been added to clean up any leftover data in temporary storage to ensure a smooth operation.
    • Additional code has been written to ensure the software can immediately send messages or data intended for the user's browser, providing a seamless user experience.
  • Changes in SapiEmitterTest.php

    • New test scenarios have been added to keep a check on the temporary storage usage level. This will help to ensure the software performance by preventing any potential software crashes due to full storage conditions.

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (d3ceae2) to head (172f226).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #58   +/-   ##
=========================================
  Coverage     99.41%   99.42%           
- Complexity      114      115    +1     
=========================================
  Files             5        5           
  Lines           343      346    +3     
=========================================
+ Hits            341      344    +3     
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xepozz xepozz marked this pull request as ready for review September 16, 2023 14:06
@xepozz xepozz requested a review from a team September 16, 2023 14:06
@xepozz xepozz added the status:code review The pull request needs review. label Sep 16, 2023
@samdark samdark added the pr:request for unit tests Unit tests are needed. label Oct 19, 2023
@samdark
Copy link
Member

samdark commented Oct 19, 2023

@xepozz is it possible to unit-test it?

@xepozz
Copy link
Member Author

xepozz commented Feb 27, 2024

@xepozz is it possible to unit-test it?

https://github.com/yiisoft/yii-runner-http/pull/58/files#diff-515447056a6d6f6a81bdc06848d9de84a5fccc9cb353d92fca2d15127dd8079bR302-R334

Tested with xepozz/internal-mocker. Need to prepare it's release and can merge it

@xepozz xepozz merged commit e635091 into master Mar 3, 2024
33 of 34 checks passed
@xepozz xepozz deleted the stream-output branch March 3, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:request for unit tests Unit tests are needed. status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants