CArrayDataProvider case insensitive

[yannyannyann]

Hello

in the CArrayDataProvider class I expect the sortData() function to be case insensitive, but it is not, because it is using the php method array_multisort http://php.net/manual/en/function.array-multisort.php

I am now fixing it by creating a separate class which extends CArrayDataProvider in order to override the sortData by calling the php method strtolower() on the elements to be sorted.
(like suggested here http://www.yiiframework.com/forum/index.php/topic/17154-case-insensitive-sort/ )

Please let me know if this could be an option of the sortData in the future ?

Thanks

Yann

[marcovtwout]

I would even expect case-insensitive sorting to be default.

Example nr4 on php.net suggests converting the array to lowercase values, as done in the solution above.

[bwoester]

In the end, it should be configurable. Maybe one wants to sort something containing numbers, so natural ordering would be handy. If the case insensitive algorithm is hard coded, you'll face the same problems as now: the data provider just doesn't behave the way you need it to behave.

Also, modifying the class to act case-insensitive by default is a bad idea for the 1.1.x release series, because it modifies behavior. Some applications might rely on case sensitive sorting. They shouldn't break because of updating the framework. So making it configurable, with just the same sorting as now as default, seems to be the best solution to me.

[BBoom]

Agree with bwoester, this should be configurable.

[resurtm]

@BBoom Natural sorting addition should be in the separate issue, IMO.

[BBoom]

@resurtm Agreed, but I think making this a configurable option is a good move to allow future expanding. A first version should probably be limited to case-insensitive sorting, to speed up implementation (and also, this is the only concrete case people have reported needing). But it would be wise to implement it in such a way that other sort styles could be implemented later. In other words, not a 'caseSensitive' boolean param, but more of a 'sortingStyle' param that takes constants.

[resurtm]

@BBoom What about another new boolean property called something like $naturalSort? Do you think this way is worse and less extendable than bit masks?

@mdomba @samdark Your opinions?

[mdomba]

how about setting an expression or anonymous function?

[bwoester]

I'm not too familiar with CArrayDataProvider source, just took a quick look. From what I see, I think the current solution with case sensitive/ insensitive flag really might be enough. If someone needs more, he can always inherit and override sortData method.

However, if someone wants to do more refactoring, to make the class more flexible, I think the sortData method could be modified slightly:

Sorting direction could be removed from the signature. If descending order is configured, this can be done by CArrayDataProvider by inverting the sorted array. No need to handle sort order in every implemented algorithm.
The sort algorithm might be invoked as a callback, or object implementing an ISortable interface. CArrayDataProvider (or yii framework in general, if sort implementations are interesting in other places) might provide case sensitive/ insensitive implementations, as well as natural sorting implementations. Another sort algorithm characteristic that comes to my mind is its stability. Does the algorithm maintain element order for elements with the same comparison key?

[samdark]

Fixed.