Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix curlOptions merging #331

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Fix curlOptions merging #331

merged 3 commits into from
Feb 9, 2023

Conversation

yuniorsk
Copy link
Contributor

@yuniorsk yuniorsk commented Feb 8, 2023 •
edited
Loading

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues #329, #330

Fix curl options merging as integer keys are discarded with array_merge

@samdark samdark added this to the 2.1.3 milestone Feb 9, 2023
@samdark samdark added the type:bug Bug label Feb 9, 2023
samdark
samdark reviewed Feb 9, 2023
View reviewed changes
Connection.php Show resolved Hide resolved
samdark
samdark approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Need a line for CHANGELOG before merging it. Please add it. Thanks.

@samdark samdark merged commit 483baae into yiisoft:master Feb 9, 2023
@samdark
Copy link
Member

samdark commented Feb 9, 2023

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HagnMarkus HagnMarkus HagnMarkus left review comments

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
type:bug Bug
Projects
None yet
Milestone
2.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@yuniorsk @samdark @HagnMarkus