beforeRun() and afterRun() do not get executed in base\Action

[ivokund]

Hi,
I see that beforeRun and afterRun were added in yii\base\Action in @a5968a6a, but I don't see that the methods get actually executed. I assume that the behaviour is supposed to be similar to that in controllers?

Excerpt from base\Action

    public function runWithParams($params)
    {
        if (!method_exists($this, 'run')) {
            throw new InvalidConfigException(get_class($this) . ' must define a "run()" method.');
        }
        $args = $this->controller->bindActionParams($this, $params);
        Yii::trace('Running action: ' . get_class($this) . '::run()', __METHOD__);
        if (Yii::$app->requestedParams === null) {
            Yii::$app->requestedParams = $args;
        }
        return call_user_func_array([$this, 'run'], $args);
    }

[cebe]

@qiangxue why did you add them, what's the usecase for them? When implementing an action you have full control over the complete flow so they are not needed imo.

[ivokund]

Imo beforeRun is convenient if (for example) you're using inheritance in action classes. You could also just override init, but it would help to have a method that's only executed after init and before running the action. Of course, this would be trivial to implement where specifically necessary.

I don't see any point in afterRun other than having a complete set of before/after methods :)

[qiangxue]

The use case is you have a base action class and you want to put some common logic that should get executed before/after action run.

I added these methods when implementing web api support which needs to check if the current request method is allowed by the action.

@ivokund the issue is valid. Need to change runWithParams().

[qiangxue]

Fixed. Thanks.

[ivokund]

I think there's a typo in your fix

    public function runWithParams($params)
    {
        if (!method_exists($this, 'run')) {
            throw new InvalidConfigException(get_class($this) . ' must define a "run()" method.');
        }
        $args = $this->controller->bindActionParams($this, $params);
        Yii::trace('Running action: ' . get_class($this) . '::run()', __METHOD__);
        if (Yii::$app->requestedParams === null) {
            Yii::$app->requestedParams = $args;
        }
        if ($this->beforeRun()) {
            call_user_func_array([$this, 'run'], $args);
            $this->afterRun();
        }
    }

The result of run is not returned so external actions do not currently work any more.