Added JSON type to MySQL and PostgreSQL schema #15560

zhukovra · 2018-01-25T21:00:34Z

Q	A
Is bugfix?	no
New feature?	yes
Breaks BC?	no
Tests pass?	yes
Fixed issues	#13019, #15247

This is fixed and tests enriched PR #13783.
Correct realization of PR #15266.

Status: working on tests stabilization under new versions of DBs.

samdark · 2018-01-26T12:50:38Z

@SilverFire I think you'd like to take a look at it.

zhukovra · 2018-01-26T13:46:54Z

@samdark FYI I want to separate that PR with excluding "Fixed default values loaded from schema for PostgreSQL" commit because I fix it for test passing on PostgreSQL 9.6.

Another important question for me is why Travis tests works on outdated and rarely used versions of databases servers? Where can I read about that decision policy?

samdark · 2018-01-26T15:04:41Z

Travis works with whatever is provided by default. We can merge adjusted travis.yml if needed.

samdark · 2018-02-04T22:08:10Z

@zhukovra would you please merge with master? Also... what's left for the pull request to be finished?

zhukovra · 2018-02-05T07:50:57Z

@samdark I'll try finish PR today or tomorrow.

SilverFire · 2018-02-05T09:22:28Z

Please pay attention to changes introduced by #15348

zhukovra · 2018-02-05T09:28:39Z

I've found a bug with JSON column type in MySQL that will not be fixed in PHP < 5.6. Failed test is here.

What do I need to do with it? Should I use version_compare() for making that test pass?

SilverFire · 2018-02-05T09:34:15Z

Yes, throw exception and leave a TODO comment to drop this check in Yii 2.1

zhukovra · 2018-02-05T21:35:58Z

@SilverFire @samdark please review.

samdark

Generally code is fine. There are minor issues to fix and questions to answer. Also a line for changelog is needed.

samdark · 2018-02-05T21:49:39Z

.travis.yml

+      - mysql-5.7-trusty
+    packages:
+      - libmysqlclient-dev
+      - libmysqlclient20


Are both libraries necessary?

Nope. Copypaste from outdated Travis instruction. Fixed.

samdark · 2018-02-05T21:49:54Z

.travis.yml

+    packages:
+      - libmysqlclient-dev
+      - libmysqlclient20
+      - mysql-community-client


Why do we need a client?

samdark · 2018-02-05T21:51:02Z

.travis.yml

-            - mysql-client-core-5.6
-            - mysql-client-5.6
+            - libmysqlclient-dev
+            - libmysqlclient20


samdark · 2018-02-05T21:51:09Z

.travis.yml

-            - mysql-client-core-5.6
-            - mysql-client-5.6
+            - libmysqlclient-dev
+            - libmysqlclient20


samdark · 2018-02-05T21:54:59Z

framework/db/SchemaBuilderTrait.php

@@ -272,4 +272,25 @@ public function money($precision = null, $scale = null)

        return $this->getDb()->getSchema()->createColumnSchemaBuilder(Schema::TYPE_MONEY, $length);
    }
+
+    /**
+     * Creates a json column.


json -> JSON

samdark · 2018-02-05T21:55:32Z

framework/db/SchemaBuilderTrait.php

+     */
+    public function json()
+    {
+        /**


Since it's not a phpdoc block, use /* with single *.

samdark · 2018-02-05T21:55:45Z

framework/db/SchemaBuilderTrait.php

+        /**
+         * TODO Remove in Yii 2.1
+         *
+         * Disabled due bug in MySQL extension


samdark · 2018-02-05T21:57:11Z

tests/framework/db/SchemaTest.php

@@ -249,7 +249,7 @@ public function testGetPDOType()

    public function getExpectedColumns()
    {
-        return [
+        $columns = [


returning it right away was fine.

samdark · 2018-02-05T21:58:39Z

tests/framework/db/mysql/QueryBuilderTest.php

-        ]);
+        ];
+
+        /**


samdark · 2018-02-05T22:05:50Z

As I understand, this PR fixes everything that #15266 was going to fix, right?

zhukovra · 2018-02-06T09:20:04Z

@samdark I think that bugs #15266 was fixed by @SilverFire. PR updated. Thank you for review.

SilverFire

Looks good to me

samdark · 2018-02-06T12:55:01Z

A line for changelog is needed.

zhukovra · 2018-02-06T13:11:45Z

framework/CHANGELOG.md

@@ -4,6 +4,7 @@ Yii Framework 2 Change Log
 2.0.14 under development
 ------------------------

+- Enh #13019: Support JSON in SchemaBuilderTrait (zhukovra, undefinedor)


@samdark but it is already there

samdark · 2018-02-06T13:35:54Z

Merged. Thank you!

titanproger · 2018-04-02T19:32:41Z

Hello every one!
I have a question about new json support on PostgreSQL.
Is it way to create a json field by migration now?
I mean not a "jsonb" but "json" type.
example

$this->createTable('table_name', [
            "id" => $this->bigPrimaryKey(),
            "body" => "json",   // warning "json" generates jsonb type
        ]);

First my think - is create own QueryBuilder width $typeMap = [
....
"json_raw" => 'json'
]
and use json_raw abstraction type.

finnan444 · 2018-04-03T10:43:02Z

@titanproger Hi, i also encountered this issue, may be you created a new issue?
BTW my Postgres creates in migration not json, but jsonb by default
IMHO, this flag should be added to \yii\db\SchemaBuilderTrait::json() as parameter

zhukovra force-pushed the develop-json branch from 4536009 to d3ed839 Compare January 25, 2018 21:32

zhukovra changed the title ~~Added JSON type to MySQL and PostgreSQL schema~~ WIP Added JSON type to MySQL and PostgreSQL schema Jan 25, 2018

zhukovra force-pushed the develop-json branch from d3ed839 to da1bd89 Compare January 25, 2018 22:29

zhukovra closed this Jan 26, 2018

zhukovra deleted the develop-json branch January 26, 2018 08:09

zhukovra reopened this Jan 26, 2018

samdark mentioned this pull request Feb 4, 2018

Added JSON type to MySQL and PostgreSQL schema #13783

Closed

Added JSON type to MySQL and PostreSQL schema

be02d1f

zhukovra force-pushed the develop-json branch from da1bd89 to 99ba1e1 Compare February 5, 2018 08:00

zhukovra force-pushed the develop-json branch from 99ba1e1 to 61a1957 Compare February 5, 2018 15:26

zhukovra changed the title ~~WIP Added JSON type to MySQL and PostgreSQL schema~~ Added JSON type to MySQL and PostgreSQL schema Feb 5, 2018

samdark approved these changes Feb 5, 2018

View reviewed changes

samdark requested a review from SilverFire February 5, 2018 22:04

samdark added this to the 2.0.14 milestone Feb 5, 2018

zhukovra force-pushed the develop-json branch from 61a1957 to 479c8da Compare February 6, 2018 09:09

Added tests for JSON type in MySQL and PostreSQL

b3aac82

zhukovra force-pushed the develop-json branch from 479c8da to b3aac82 Compare February 6, 2018 09:16

SilverFire approved these changes Feb 6, 2018

View reviewed changes

zhukovra commented Feb 6, 2018

View reviewed changes

samdark merged commit 40b0383 into yiisoft:master Feb 6, 2018

titanproger mentioned this pull request Apr 3, 2018

Create "json" field on PostgreSQL by migration Yii 2.0.14.1 #16029

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added JSON type to MySQL and PostgreSQL schema #15560

Added JSON type to MySQL and PostgreSQL schema #15560

zhukovra commented Jan 25, 2018 •

edited

Loading

samdark commented Jan 26, 2018

zhukovra commented Jan 26, 2018

samdark commented Jan 26, 2018

samdark commented Feb 4, 2018

zhukovra commented Feb 5, 2018

SilverFire commented Feb 5, 2018

zhukovra commented Feb 5, 2018

SilverFire commented Feb 5, 2018

zhukovra commented Feb 5, 2018

samdark left a comment

samdark Feb 5, 2018

zhukovra Feb 6, 2018

samdark Feb 5, 2018

samdark Feb 5, 2018

samdark Feb 5, 2018

samdark Feb 5, 2018

samdark Feb 5, 2018

samdark Feb 5, 2018

samdark Feb 5, 2018

samdark Feb 5, 2018

samdark commented Feb 5, 2018

zhukovra commented Feb 6, 2018

SilverFire left a comment

samdark commented Feb 6, 2018

zhukovra Feb 6, 2018

samdark commented Feb 6, 2018

titanproger commented Apr 2, 2018

finnan444 commented Apr 3, 2018 •

edited

Loading

-                      ]);
+                      ];
+                      /**

Added JSON type to MySQL and PostgreSQL schema #15560

Added JSON type to MySQL and PostgreSQL schema #15560

Conversation

zhukovra commented Jan 25, 2018 • edited Loading

samdark commented Jan 26, 2018

zhukovra commented Jan 26, 2018

samdark commented Jan 26, 2018

samdark commented Feb 4, 2018

zhukovra commented Feb 5, 2018

SilverFire commented Feb 5, 2018

zhukovra commented Feb 5, 2018

SilverFire commented Feb 5, 2018

zhukovra commented Feb 5, 2018

samdark left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samdark commented Feb 5, 2018

zhukovra commented Feb 6, 2018

SilverFire left a comment

Choose a reason for hiding this comment

samdark commented Feb 6, 2018

Choose a reason for hiding this comment

samdark commented Feb 6, 2018

titanproger commented Apr 2, 2018

finnan444 commented Apr 3, 2018 • edited Loading

zhukovra commented Jan 25, 2018 •

edited

Loading

finnan444 commented Apr 3, 2018 •

edited

Loading