[minor] SCA: minor code tweaks #15571
Conversation
kalessil
commented
Jan 29, 2018
kalessil
commented
| Q | A |
|---|---|
| Is bugfix? | no |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | no |
| Fixed issues | n/a |
| @@ -874,7 +874,7 @@ protected function splitChangelog($file, $version) | |||
| $state = 'end'; | |||
| } | |||
| // add continued lines to the last item to keep them together | |||
| if (!empty(${$state}) && trim($line !== '') && strpos($line, '- ') !== 0) { | |||
| if (!empty(${$state}) && trim($line) !== '' && strncmp($line, '- ', 2) !== 0) { | |||
There was a problem hiding this comment.
A little bit, but due to weak typing this worked. I just noticed that we can drop trim($line) !== '' here at all, should I do it?
| @@ -307,7 +307,7 @@ public function testBatchInsert() | |||
|
|
|||
| public function testBatchInsertWithYield() | |||
| { | |||
| if (version_compare(PHP_VERSION, '5.5', '<')) { | |||
| if (PHP_VERSION_ID < 50500) { | |||
There was a problem hiding this comment.
Optimizer friendly, in case of the constant it can drop the branch when generating opcodes. One thing I'm not sure if it should be prefixed with '\' for this or not. if I find the link where this described, I'll poke you at Twitter.
There was a problem hiding this comment.
That's actually OK and makes sense but in this case it's up to code style (performance difference doesn't matter much).
|
@samdark : will it be welcome a PR covering this case https://github.com/symfony/symfony/pull/25854/files (it's 10-20 functions like that) ? |
|
Yes. |
|
Super, thank you. I'll create a separate one today (evening or so). |
|
Thank you for code improvements. |
|
👍 |
