Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support fractional seconds for time types. Actually for MySQL >= 5.6.4 #16209

Merged
merged 10 commits into from
Oct 11, 2018

Conversation

kos-v
Copy link
Contributor

@kos-v kos-v commented May 2, 2018

Q A
Is bugfix? yes
New feature? yes
Breaks BC? no
Tests pass? yes
Fixed issues #14367

@samdark samdark added the pr:request for unit tests Unit tests are needed. label May 2, 2018
@yii-bot
Copy link

yii-bot commented May 2, 2018

Thank you for putting effort in the improvement of the Yii framework.
We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

@kos-v kos-v changed the title #14367 added support fractional seconds for time types. Actually for MySQL >= 5.6.4 added support fractional seconds for time types. Actually for MySQL >= 5.6.4 May 3, 2018
@SilverFire SilverFire added this to the 2.0.16 milestone May 4, 2018
@samdark samdark added type:bug Bug and removed pr:request for unit tests Unit tests are needed. labels May 13, 2018
@samdark samdark requested a review from SilverFire May 13, 2018 20:05
@samdark samdark merged commit 9f383ab into yiisoft:master Oct 11, 2018
@samdark
Copy link
Member

samdark commented Oct 11, 2018

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants