Arrayhelper filter support more than 2 levels #17830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data when passing a filter with more than 2 levels
…ilter` when passing a filter with more than 2 levels
xepozz
suggested changes
Jan 27, 2020
|
|
||
| //We've found a value now let's insert it | ||
| $resultNode = &$result; | ||
| foreach ($keys as $key) { |
There was a problem hiding this comment.
Can you merge this loop with previous?
There was a problem hiding this comment.
Nope, let's say we have a filter 'A.B' and the source does have key A but that level does not have key B in it, the resulting array would be set [A => []] while it should return [].
There was a problem hiding this comment.
Yes, the test would fail at line 1336 $this->assertEquals(ArrayHelper::filter($array, ['A.X']), []);.
samdark
approved these changes
Jan 28, 2020
|
Merged. Thank you! It would be cool to have it ported to Yii 3 yiisoft/arrays#15 |
samdark
added a commit
to yiisoft/arrays
that referenced
this pull request
Feb 21, 2020
…th more than 2 levels Ported from yiisoft/yii2#17830 Thanks, @rhertogh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayHelper::filterwas used in an unexpected way)