-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of redux in component #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status: Approved ✔️ ✔️ ✔️
Hi @yin-ka 👋
Well done on implementing the requirements on the first try. 👍
Your project is complete now! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
To Highlight 👏🏻
✔️ Dispatch actions used.
✔️ Create an initial-state in bookSlice.
✔️ Add button working fine.
✔️ Remove button working fine.
✔️ The app is working fine.
Optional suggestions 🤷♂️
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Important Notes 📝
- Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
- Please, remember to tag me in your question so I can receive the notification.
- You can mail me at or ask any question at Slack,
Name: Tufahel
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
dispatch(addBook({ | ||
itemId: `item${id + 1}`, | ||
title, | ||
author, | ||
})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Well done. 👍 I like the way you increased item id. Though it seems easy, most of the students missed it.
- Keep it up and happy coding. 😄
In this project, I have: