Connect api #4
Connect api #4
Conversation
There was a problem hiding this comment.
Status: Required Changes ♻️
Hi @yin-ka,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Redux toolkits used in the app. ✔️
- Good README file. ✔️
- Correct Gitflow. ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/components/AddBook.js
Outdated
| const clickHandler = () => { | ||
| const id = Math.floor(Math.random() * 1000000); | ||
| dispatch(addBook({ | ||
| itemId: `item${id + 1}`, | ||
| item_id: `itemId${id + 1}`, | ||
| title, | ||
| author, | ||
| category: 'Action', | ||
| })); |
There was a problem hiding this comment.
- Great work so far. However, there's little issue with your form. You forgot to prevent form default refresh when the button type is
submit. This has made your app to behave inconsistently. The app keep refreshing while trying to add a book due to the fact that, default refresh is not prevented. Kindly add that to the function. It looks something similar to this. 👇
const clickHandler = (e) => {
e.preventDefault();
}
App behavior
app.webm
- [OPTIONAL] It is even better to use onSubmit event handler in the form opening tag. Something like this.
<form onSubmit={clickHandler}>
There was a problem hiding this comment.
Okay, thank you. Will work on that.
There was a problem hiding this comment.
STATUS: MILESTONE APPROVED 🥇
Hi @yin-ka ,
Great job !!!
To Highlight! 👏 🟢
✔️ Change requested by previous reviewer implemented
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this project, I: