Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling #5

Merged
merged 6 commits into from
Jul 21, 2023
Merged

Styling #5

merged 6 commits into from
Jul 21, 2023

Conversation

yin-ka
Copy link
Owner

@yin-ka yin-ka commented Jul 21, 2023

In this project, I:

  • Added missing JSX elements to the project (without adding extra functionality)

  • Made the final design match Zeplin's design (this includes all elements + the same styling)

Copy link

@Lizdev-05 Lizdev-05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yin-ka ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

✔️ Professional Readme file 👍
✔️ Good commit history 👍
✔️ No linter error 👍
✔️ Nice IU design👍

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@yin-ka yin-ka merged commit 2944423 into Dev Jul 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants