Set a fixed number of pairs for GA2M #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,6 +69,9 @@ | |||
|
|
|||
| @Argument(name = "-l", description = "learning rate (default: 0.01)") | |||
| double learningRate = 0.01; | |||
|
|
|||
| @Argument(name = "-p", description = "maximum number of pairs") | |||
There was a problem hiding this comment.
I would not add this parameter since the input pairs is required and specified by '-I'. If called from other program, the caller should have a sense how many pairs to use and provide the list of pairs.
There was a problem hiding this comment.
So you would rather modify the interaction file created by FAST to keep only the first numPairs lines ? but this mean one would always have to create a new file whenever we want to test another value of numPairs
There was a problem hiding this comment.
FAST only ranks all pairs. The typical usage of this code is run FAST to get the ranking of all pairs, use head command to get the top K pairs and save it to a new file, feed the new file to GA2MLearner.
yinlou
pushed a commit
that referenced
this pull request
Apr 1, 2016
Latest changes from yinlou/mltk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, I've added a new parameter '-p' to set the number of pairs we'd like to use (default is all of them). When reading the interactions file, we stop when we've reached the desired number of pairs.
This PR also fixes a bug:
setPairswas missing inmain.