Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge updates before applying #7

Closed
wants to merge 1 commit into from
Closed

Conversation

georeith
Copy link

Fixes an issue where this hangs for a long time if there are a large number of upates.

Before (2.5 minutes):

image

After (1.4 seconds):

image

See ueberdosis/hocuspocus#230 for more context.

@sevaplan
Copy link

@dmonad @georeith is there a reason why this is not getting merged? I mean, what are the downsides to do that?

P.S. We are building a product on top of yjs, and right now figuring out all the persistence layers needed, please share if there is any guides available, as for now I am mostly reading source code and experimenting, which is fine, but I feel that I miss some fundamentals

@thewoolleyman
Copy link

@dmonad friendly bump! I'm also considering using this library, but trying to assess the stability/risks of committing to it.

I realize you have said you do not have time to actively work on this, but are there perhaps some other people in https://opencollective.com/y-collective that could help ensure that pull requests get promptly reviewed/merged?

If not, how could this situation be helped? Stepping up as a potential maintainer? Contributions? Something else?

@dmonad dmonad closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants