Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all contributors GitHub Action #6

Closed
CBID2 opened this issue Jan 20, 2024 · 20 comments
Closed

Add all contributors GitHub Action #6

CBID2 opened this issue Jan 20, 2024 · 20 comments

Comments

@CBID2
Copy link
Contributor

CBID2 commented Jan 20, 2024

I have seen other projects use this bot in their Contributing.MD file and thought this would be a good thing to put too.

@ykdojo
Copy link
Owner

ykdojo commented Jan 20, 2024

What does it do exactly?

@CBID2
Copy link
Contributor Author

CBID2 commented Jan 21, 2024

What does it do exactly?

It shows a list of people who have contributed to your project.

@ykdojo
Copy link
Owner

ykdojo commented Jan 21, 2024

I'm not sure if that's necessary. We kind of already have that on GitHub, and we can manually add most active contributors later.

@ykdojo
Copy link
Owner

ykdojo commented Feb 3, 2024

Since I'm still not sure if/why this is necessary, I'll close this issue if there's no objective.

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 3, 2024

Since I'm still not sure if/why this is necessary, I'll close this issue if there's no objective.

It'll make it easier you to add the contributors to your ReadMe @ykdojo. From what I've heard from other maintainers, it's a lot of work to do it manually.

@ykdojo
Copy link
Owner

ykdojo commented Feb 3, 2024

Hmm interesting. I'm not sure how helpful it is though. We already have this: https://github.com/ykdojo/OpenStream/graphs/contributors

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 3, 2024

Hmm interesting. I'm not sure how helpful it is though. We already have this: https://github.com/ykdojo/OpenStream/graphs/contributors
The GitHub version mostly focuses on the contributors’ commit history, which gives the impression that only code contributions are accepted. The GitHub action on the other hand, specifies the ways other people have contributed and hyperlinks their social profiles. This can encourage people from all backgrounds to come and contribute to the project as well as give them an opportunity to see the work they do beyond GitHub.

@ykdojo
Copy link
Owner

ykdojo commented Feb 4, 2024

I see. I still think it's better to do it manually. That way, we can have people send a PR adding their name if they feel like they've made a significant contribution especially if it's outside of GitHub?

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 4, 2024

I see. I still think it's better to do it manually. That way, we can have people send a PR adding their name if they feel like they've made a significant contribution especially if it's outside of GitHub?

I don't know @ykdojo. From what I've seen, contributors do tend to like the acknowledgement no matter how or small the contribution is. Also, having them add it manually adds an extra layer of work, which can be tiring, especially if a contributor has just finished making a major PR. I really think we should try this GitHub Action. It's been effective in other projects I've contributed to.

@ykdojo
Copy link
Owner

ykdojo commented Feb 4, 2024

I see. It might be worth trying then. It's free?

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 4, 2024

I see. It might be worth trying then. It's free?

Great! :) Yes it is free @ykdojo

@ykdojo
Copy link
Owner

ykdojo commented Feb 5, 2024

I've thought about this, and I realized what'd be helpful is having the contributor's name, Discord name, and social media handle if they want to add it.

I feel like the best way to do this is simply by asking them to add themselves to a table of contributors.

Thoughts?

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 5, 2024

I've thought about this, and I realized what'd be helpful is having the contributor's name, Discord name, and social media handle if they want to add it.

I feel like the best way to do this is simply by asking them to add themselves to a table of contributors.

Thoughts?

Hi @ykdojo. Ehh, I still think that the GitHub Action would be best.

@ykdojo
Copy link
Owner

ykdojo commented Feb 5, 2024

Can you explain why and how what I described can be achieved with it?

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 6, 2024

Can you explain why and how what I described can be achieved with it?

@ykdojo, it'll allow to focus more on maintaining the project. Also, it'll automatically create the table for you,thus gaining an increase in productivity.

@ykdojo
Copy link
Owner

ykdojo commented Feb 7, 2024

But we'll need to have the contributors add other info like their Discord and social media handles on their own anyway?

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 7, 2024

But we'll need to have the contributors add other info like their Discord and social media handles on their own anyway?
@ykdojo, it'll hyperlink their GitHub profile, so contributors don't need to add their Discord or social media

@ykdojo
Copy link
Owner

ykdojo commented Feb 8, 2024

This is what I said earlier:

I've thought about this, and I realized what'd be helpful is having the contributor's name, Discord name, and social media handle if they want to add it.

I feel like the best way to do this is simply by asking them to add themselves to a table of contributors.

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 8, 2024

This is what I said earlier:

I've thought about this, and I realized what'd be helpful is having the contributor's name, Discord name, and social media handle if they want to add it.

I feel like the best way to do this is simply by asking them to add themselves to a table of contributors.

Ok @ykdojo

@ykdojo ykdojo closed this as completed Feb 17, 2024
@ykdojo
Copy link
Owner

ykdojo commented Feb 17, 2024

#33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants