Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pull request template #7

Closed
CBID2 opened this issue Jan 20, 2024 · 12 comments · Fixed by #28
Closed

Add a pull request template #7

CBID2 opened this issue Jan 20, 2024 · 12 comments · Fixed by #28

Comments

@CBID2
Copy link
Contributor

CBID2 commented Jan 20, 2024

This would aid contributors on submitting their PR, especially if it’s their first time contributing to an open source project.

@BlackBond06
Copy link

Hi @CBID2 @ykdojo I have made a PR for this issue, please review.

@ykdojo ykdojo changed the title Add a Pull Request template Add a pull request template Feb 3, 2024
@ykdojo
Copy link
Owner

ykdojo commented Feb 3, 2024

Add a few comments @BlackBond06

@ykdojo
Copy link
Owner

ykdojo commented Feb 4, 2024

Closed it #19 as I mentioned as I would.

@ykdojo
Copy link
Owner

ykdojo commented Feb 4, 2024

This would aid contributors on submitting their PR, especially if it’s their first time contributing to an open source project.

Explaining how this would be helpful specifically might be helpful to clarify the intent of this issue @CBID2.

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 4, 2024

This would aid contributors on submitting their PR, especially if it’s their first time contributing to an open source project.

Explaining how this would be helpful specifically might be helpful to clarify the intent of this issue @CBID2.

Sure @ykdojo. In my experience maintaining projects that use PR templates, they add context about a person's contribution(s), making it easier for us and other contributors to give effective feedback.

@ykdojo
Copy link
Owner

ykdojo commented Feb 4, 2024

Got it. Let us know if you have a specific format / questions in mind.

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 6, 2024

Got it. Let us know if you have a specific format / questions in mind.

Hi @ykdojo. Here's what I came up with
pull_request_template.md

@ykdojo
Copy link
Owner

ykdojo commented Feb 6, 2024

I think it's nice! Very simple. We can keep adding more stuff to it in the future if necessary.

@ykdojo
Copy link
Owner

ykdojo commented Feb 6, 2024

Changes Proposed should be Changes proposed for consistency though

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 6, 2024

Changes Proposed should be Changes proposed for consistency though

Great @ykdojo! :) I'll do the PR right away

@CBID2
Copy link
Contributor Author

CBID2 commented Feb 6, 2024

Changes Proposed should be Changes proposed for consistency though

As promised, PR is done. Check out #28

@ykdojo
Copy link
Owner

ykdojo commented Feb 7, 2024

Added a comment on #28!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants