Include top 5 reflection memories in converse() function #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
1 task
ykhli
reviewed
Aug 16, 2023
| : ''; | ||
| const relevantMemories: string = conversationMemories | ||
| .slice(0, 2) // only use the first 2 memories | ||
| const relevantReflections: string = reflectionMemories |
There was a problem hiding this comment.
do .slice(0.5) on this object instead.
ykhli
reviewed
Aug 16, 2023
| @@ -147,6 +143,7 @@ export async function converse( | |||
| prefixPrompt += `Last time you chatted with some of ${nearbyPlayersNames} it was ${lastConversationTs}. It's now ${Date.now()}. You can cut this conversation short if you talked to this group of people within the last day. \n}`; | |||
|
|
|||
| prefixPrompt += `Below are relevant memories to this conversation you are having right now: ${relevantMemories}\n`; | |||
| prefixPrompt += `Below are your recent reflections: ${relevantReflections}\n`; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue #5 by modifying the
converse()function inconversation.tsto include the top 5 reflection memories in the chat prompt. Currently, the function only fetches conversation memories and does not consider reflection memories. This update ensures that the chat prompt includes relevant reflection memories, providing a more contextually aware conversation experience.Summary of Changes
filterMemoriesTypefunction from./lib/memoryinconversation.ts.converse()function to fetch the top 5 reflection memories usingfilterMemoriesType()with 'reflection' as the memory type.prefixPromptvariable to include thereflectionMemoriesin the chat prompt.prefixPromptto include the descriptions of the relevant reflection memories.fix-converse-functionfor these changes.Fixes #5.
To checkout this PR branch, run the following command in your terminal:
To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.