-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Add custom CockroachSchemaManager and override selectTableColumns() / fixes #35 #36
base: main
Are you sure you want to change the base?
[BUGFIX] Add custom CockroachSchemaManager and override selectTableColumns() / fixes #35 #36
Conversation
Add a.attisdropped = false flag to compile columns sql to fix the output of Schema::getColumns(). Add custom cockroach db driver for loading the custom cockroach schema manager to fix renaming issue ylsideas#35
7d960bf
to
1d178bc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
============================================
+ Coverage 91.39% 93.12% +1.73%
- Complexity 32 39 +7
============================================
Files 7 9 +2
Lines 93 131 +38
============================================
+ Hits 85 122 +37
- Misses 8 9 +1 ☔ View full report in Codecov by Sentry. |
@Vision42 I was unable to push fixes directly to your branch but I've created a patch file. cockroachdb-laravel-320d3be-Add mechanism to handle failing with outdated DBAL.patch What my changes do, is it will allow users to use the package with outdated Dbal installs but it will flag an exception that they should warn they need to update to a new version. For the tests, if Dbal is below 3.5 then those tests will be skipped. This feels like the best way to make users aware that they might have problems if they're using an outdated package without forcing it as Dbal isn't a Laravel dependency and I don't want to make it one for this package either especially as it's no longer used in Laravel 11. I just want to say thank you for your patience and hard work on this as well. Projects like this one only really work with contributors such as yourself. |
Changes In Code
Add custom
CockroachSchemaManager
extending thePostgreSQLSchemaManager
and override theselectTableColumns()
function to add thea.attisdropped = false
flag to the SQL query.Additionally override
compileColumns
function inCockroachGrammar
-Class to fix the output of theSchema::getColumns
function.Issue ticket number / Business Case
#35
Checklist before requesting a review