Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Added EntityBrowserFormTrait (Activity Finder 4). #2328

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

duozersk
Copy link
Contributor

@duozersk duozersk commented Dec 8, 2020

Added EntityBrowserFormTrait class used in Activity Finder 4.

@gundevel
Copy link
Collaborator

gundevel commented Dec 8, 2020

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@ghost
Copy link

ghost commented Dec 8, 2020

DeepCode's analysis on #9ce42b found:

  • ⚠️ 1 warning 👇

Top issues

Description Example fixes
MD5 hash (used in md5) is insecure. Consider changing it to a secure hashing algorithm (e.g. SHA256). Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@podarok podarok added Backporting Requests to backport features from YMCAs to the Open Y Distribution Five Jars Assigned for resolution Level: Advanced Complex task. Usually for Core team PR: Code Reviewed Code reviewed. Ready for QA Severity: Normal Not critical, but still important. Selected for development. Type: Task Maintenance, subtasks labels Dec 8, 2020
@podarok
Copy link
Contributor

podarok commented Dec 8, 2020

How urgent is this? @duozersk

@duozersk
Copy link
Contributor Author

duozersk commented Dec 8, 2020

@podarok It is not urgent at all - I just needed a patch to reference for now. Will post here once it becomes more relevant.

@podarok
Copy link
Contributor

podarok commented Dec 8, 2020

Ok, great, thank you @duozersk

This is a backporting, code needed for external dependency @sarah-halby
It adds 0 functionality for Open Y - needed only in Activity Finder v4 as a dependency.

I'm fine with merging it even now because of 0 chance for any bugs or regressions. But technically this is a feature.
We can keep this PR up until needed for AFv4 without risk of code conflicts or code outdated.

@podarok podarok added the PR: DO NOT MERGE Work in Progress or something not to be merged at all label Dec 8, 2020
@podarok podarok removed the PR: DO NOT MERGE Work in Progress or something not to be merged at all label Dec 22, 2020
@podarok podarok merged commit f06361f into ymcatwincities:8.x-2.x Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backporting Requests to backport features from YMCAs to the Open Y Distribution Five Jars Assigned for resolution Level: Advanced Complex task. Usually for Core team PR: Code Reviewed Code reviewed. Ready for QA Severity: Normal Not critical, but still important. Selected for development. Type: Task Maintenance, subtasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants