Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[MAINTAIN-30] fixed layout for a taxonomy term pages #2417

Merged
merged 1 commit into from
Mar 2, 2021
Merged

[MAINTAIN-30] fixed layout for a taxonomy term pages #2417

merged 1 commit into from
Mar 2, 2021

Conversation

aleevas
Copy link
Contributor

@aleevas aleevas commented Mar 2, 2021

Original Issue, this PR is going to fix: MAINTAIN-30

This one should fix broken layout for news category page when you add the alert banner on the category page page for Carnation theme.
Now it should looks like this:
MAINTAIN-30CarnationNewsCategoryPage

Steps for review

  • Make sure that you use Carnation theme.
  • Go to the news page (/news)
  • Click by one of the news
  • On the news page in right sidebar click by category tag (for ex. Summer Day Camp)
  • Verify that page looks good
  • Create a new one or just edit esixting one of Alert node
  • Please set in the Visibility pages field: news/* (to show alert on the news pages)
  • Repeat step 1-3
  • Verify that page looks good on all type of screens (desktop, tablet, mobile)

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer. See Code of Conduct.
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

@gundevel
Copy link
Collaborator

gundevel commented Mar 2, 2021

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@hamrant hamrant added the PR: DO NOT MERGE Work in Progress or something not to be merged at all label Mar 2, 2021
@hamrant hamrant self-requested a review March 2, 2021 09:41
@hamrant
Copy link
Contributor

hamrant commented Mar 2, 2021

ok to test

@gundevel
Copy link
Collaborator

gundevel commented Mar 2, 2021

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3112/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3112/

@gundevel
Copy link
Collaborator

gundevel commented Mar 2, 2021

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3112/

@gundevel
Copy link
Collaborator

gundevel commented Mar 2, 2021

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3113/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3113/

@gundevel
Copy link
Collaborator

gundevel commented Mar 2, 2021

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3113/

@aleevas aleevas marked this pull request as ready for review March 2, 2021 10:13
@podarok podarok merged commit 5784c5f into ymcatwincities:9.x-2.x Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: DO NOT MERGE Work in Progress or something not to be merged at all
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants