Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Repair footer alerts for Lily & Rose (backport for 8.x) #2429

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Repair footer alerts for Lily & Rose (backport for 8.x) #2429

merged 2 commits into from
Apr 2, 2021

Conversation

froboy
Copy link
Collaborator

@froboy froboy commented Apr 1, 2021

Original Issue, this PR is going to fix: #2427

This is a backport of #2428 for use on Open Y 8.x

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use 9.x-2.x branch. We'll tag for release if the bug is critical asap or tag for release next bug fix release until critical issue arrived.

Steps for review

See #2428

General checks

  • All coding styles are fulfilled and there are no any issues reported by CodeSniffer. See Code of Conduct.
  • Documentation has been updated according to PR changes.
  • Steps for review have been provided according to PR changes.
    Steps for review
  • Make sure you've provided all necessary hook_update_N to support upgrade path.
  • Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

@gundevel
Copy link
Collaborator

gundevel commented Apr 1, 2021

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@podarok
Copy link
Contributor

podarok commented Apr 1, 2021

ok to test

@gundevel
Copy link
Collaborator

gundevel commented Apr 1, 2021

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3126/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3126/

@froboy froboy changed the title Footer alerts backport Repair footer alerts for Lily & Rose (backport for 8.x) Apr 1, 2021
@froboy froboy marked this pull request as ready for review April 1, 2021 17:09
@gundevel
Copy link
Collaborator

gundevel commented Apr 1, 2021

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3126/

@gundevel
Copy link
Collaborator

gundevel commented Apr 1, 2021

Open Y Complete profile installed at http://openy.cibox.tools/build3126/

@podarok
Copy link
Contributor

podarok commented Apr 2, 2021

Merging in dev.
If we ever decide to do release of D8 - this will be included there

@podarok podarok merged commit 4eefed3 into ymcatwincities:8.x-2.x Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants