Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Add the hook_openy_daxko2_activity_finder_daxko_params_alter() #2480

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

dchubar-fj
Copy link
Contributor

@dchubar-fj dchubar-fj commented Jun 22, 2021

Added a new hook_openy_daxko2_activity_finder_daxko_params_alter() hook to the openy_daxko2 module. The hook allows you to change or add new query params to the Daxko search request for Activity Finder backend,

Steps for review

  • Verify the Activity Finder with Daxko backend works fine

General checks

Thank you for your contribution!

@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3219/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3219/

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3219/

@dchubar-fj dchubar-fj marked this pull request as ready for review June 22, 2021 10:05
@dchubar-fj dchubar-fj added PR: Needs Review Needs someone review ( code ) PR: Needs Testing Manual testing is needed labels Jun 22, 2021
@podarok podarok added the Type: Enhancement Change request. New functionality. label Jun 22, 2021
@podarok podarok added Daxko Related to Daxko integration Level: Advanced Complex task. Usually for Core team PR: Code Reviewed Code reviewed. Ready for QA and removed PR: Needs Review Needs someone review ( code ) labels Jun 22, 2021
@podarok
Copy link
Contributor

podarok commented Jun 22, 2021

retest this please

@podarok podarok added the Needs approval Needs approval by YUSA or/and OpenY core team label Jun 22, 2021
@podarok
Copy link
Contributor

podarok commented Jun 22, 2021

@dchubar-fj would be great to show a bit of information for future testing of this issue
A couple of screenshots or a bit more help in api.php file you already provided.
This is needed for @sarah-halby and @gianni-imagex and for the YUSA to understand

I call this Development Experience Enchancement and I'm fine with merging it

@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3227/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3227/

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3227/

@podarok podarok merged commit 9a86118 into 9.x-2.x Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Daxko Related to Daxko integration Level: Advanced Complex task. Usually for Core team Needs approval Needs approval by YUSA or/and OpenY core team PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed Type: Enhancement Change request. New functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants