Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[carnation] Fix for openy subcategory page image resize issue. #2545

Merged
merged 1 commit into from
Sep 20, 2021
Merged

[carnation] Fix for openy subcategory page image resize issue. #2545

merged 1 commit into from
Sep 20, 2021

Conversation

bharath-kondeti
Copy link
Contributor

@bharath-kondeti bharath-kondeti commented Sep 14, 2021

Fixes: #2539

Steps to test:

  • Visit an openy site.
  • Go to the program subcategory page preferably with category listing block present in that.
  • Now, adjust the content for the program subcategories that displayed in that page and reduce the description to two or three words and save the content. Next, refresh the page.
  • Adjust the browser to different breakpoints for mobile devices to check the fix for the issue.

@gundevel
Copy link
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@bharath-kondeti bharath-kondeti marked this pull request as ready for review September 15, 2021 17:21
@bharath-kondeti
Copy link
Contributor Author

o+k to test

@podarok
Copy link
Contributor

podarok commented Sep 16, 2021

@bharath-kondeti I see you have a change in compiled main.js file, but there is no source js change in PR.
Could you add it as well?
I want to ensure we are not losing your change once main.js recompiled next time without your change in source files

@podarok podarok added Level: Middle Needs skilled developer to work on PR: Needs Work Unfinished task. Issues still there labels Sep 16, 2021
@bharath-kondeti
Copy link
Contributor Author

@podarok, I did not make any changes to any JS file. When I complied my css change there were changes in both styles.css and main.js as well. Hence, i have added those as a part of this PR.

@podarok podarok changed the title Fix for openy subcategory page image resize issue. [carnation] Fix for openy subcategory page image resize issue. Sep 20, 2021
@podarok podarok added javascript Pull requests that update Javascript code Severity: Normal Not critical, but still important. Selected for development. Type: Bug Bug. Something is not working as intended. and removed PR: Needs Work Unfinished task. Issues still there labels Sep 20, 2021
@podarok podarok merged commit 7cd9400 into ymcatwincities:9.x-2.x Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript Pull requests that update Javascript code Level: Middle Needs skilled developer to work on Severity: Normal Not critical, but still important. Selected for development. Type: Bug Bug. Something is not working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carnation: Subprogram listing item images not 100% on mobile
3 participants