Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

fix(join-form): prevent Google Translate from affecting submit buttons #2546 #2547

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

kdginther
Copy link
Contributor

@kdginther kdginther commented Sep 16, 2021

Original Issue, this PR is going to fix: #2546

Credit to @podarok for the suggestion on how to fix.

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use 9.x-2.x branch. We'll tag for release if the bug is critical asap or tag for release next bug fix release until critical issue arrived.

General checks

Thank you for your contribution!

@gundevel
Copy link
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@podarok
Copy link
Contributor

podarok commented Sep 16, 2021

ok to test

@podarok
Copy link
Contributor

podarok commented Sep 16, 2021

retest this please

@ymcatwincities ymcatwincities deleted a comment from gundevel Sep 16, 2021
@kdginther
Copy link
Contributor Author

Is this something on my end, or on the automated side?

@podarok
Copy link
Contributor

podarok commented Sep 16, 2021

Is this something on my end, or on the automated side?

No worries. It's CI failing after I was on vacation for 10 days. Robots on strike

@ymcatwincities ymcatwincities deleted a comment from gundevel Sep 16, 2021
@podarok
Copy link
Contributor

podarok commented Sep 16, 2021

retest this please

@ymcatwincities ymcatwincities deleted a comment from gundevel Sep 17, 2021
@podarok
Copy link
Contributor

podarok commented Sep 17, 2021

retest this please

@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3418/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3418/

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3418/

@podarok podarok added javascript Pull requests that update Javascript code Level: Middle Needs skilled developer to work on PR: Code Reviewed Code reviewed. Ready for QA PR: Tested Manually tested. Green light for merging Severity: Normal Not critical, but still important. Selected for development. Type: Bug Bug. Something is not working as intended. labels Sep 17, 2021
@podarok podarok merged commit f0b4beb into ymcatwincities:9.x-2.x Sep 17, 2021
@shelleygoetz
Copy link
Collaborator

Issue moved to Jira: https://openy.atlassian.net/browse/MAINTAIN-169

@gundevel
Copy link
Collaborator

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript Pull requests that update Javascript code Level: Middle Needs skilled developer to work on PR: Code Reviewed Code reviewed. Ready for QA PR: Tested Manually tested. Green light for merging Severity: Normal Not critical, but still important. Selected for development. Type: Bug Bug. Something is not working as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multistep Join form has validation issues when Google Translate is active
4 participants