Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

[MAINTAIN-122] Remove excessive space for small webforms. #2568

Merged
merged 3 commits into from
Oct 12, 2021

Conversation

manachynskyi
Copy link
Contributor

@manachynskyi manachynskyi commented Oct 8, 2021

Original Issue, this PR is going to fix excessive space for small webforms for Carnation theme.

Before: https://i.imgur.com/an6E1rX.png
After: https://i.imgur.com/ffpYzqX.png

Steps for review (should be tested on Carnation)

@gundevel
Copy link
Collaborator

gundevel commented Oct 8, 2021

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@podarok
Copy link
Contributor

podarok commented Oct 12, 2021

@manachynskyi I've merged a fix for scss paths. Could you remove DO_NOT_MERGE tag from this?

@podarok podarok added Severity: Normal Not critical, but still important. Selected for development. Status: Needs work Unfinished task. Issues still there labels Oct 12, 2021
@manachynskyi manachynskyi changed the title [WIP][MAINTAIN-122] Remove excessive space for small webforms. [MAINTAIN-122] Remove excessive space for small webforms. Oct 12, 2021
@hamrant hamrant added Five Jars Assigned for resolution PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed and removed Status: Needs work Unfinished task. Issues still there labels Oct 12, 2021
@hamrant hamrant requested a review from podarok October 12, 2021 13:25
@hamrant
Copy link
Contributor

hamrant commented Oct 12, 2021

ok to test

@gundevel
Copy link
Collaborator

Build comment file:

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build3504/install.php


Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/3504/

@gundevel
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build3504/

Copy link
Contributor

@podarok podarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@podarok podarok merged commit ac13a94 into ymcatwincities:9.x-2.x Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Five Jars Assigned for resolution PR: Code Reviewed Code reviewed. Ready for QA PR: Needs Testing Manual testing is needed Severity: Normal Not critical, but still important. Selected for development.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants