Add tracepoint for generic publisher/subscriber #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-suzuki-isp
changed the title
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
h-suzuki-isp
force-pushed
the
output_tracepoint
branch
from
4cbd472
to
19752e3
Compare
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: h-suzuki-isp <146712054+h-suzuki-isp@users.noreply.github.com>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki-isp <h-suzuki@isp.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm developed member of CARET for real-time analysis using ros2tracing.
In communication through GenericPublisher/Subscription, message tracking was not possible due to a lack of trace data.
In this PR, added trace points to the GenericPublisher and GenericSubscription.
GenericPublisher
I have added the following trace points.
GenericSubscription
There was a recent PR that made
create_generic_subscriptiongo through AnySubscriptionCallback. This change causedcallbackto be captured by the lambda, resulting in it being copied andcallbackaddress was changed. In this case, the addresses of trace points outputed at initialization and runtime were different. Therefore, I modified to ensure that they have the samecallbackaddress .And, I have added the following trace points.
Additionally, with these changes, I submitted a PR to the following repository.
Add tracepoint for publish_serialized_message rcl#1
Add tracepoint for publish/subscribe serialized message rmw_fastrtps#1
Add tracepoint for publish/subscribe serialized message. rmw_cyclonedds#1