Fusion: Tweak Fusion integration #2769

BigRoy · 2022-02-20T21:18:11Z

Brief description

This is a replacement PR for #2752 with the code coming from our studio's colorbleed branch which had tweaks done to the Fusion integration.

Description

This is a first pass to expose the tweak we've been doing on our end to discuss the changes.

Instead of copying scripts into the user's local Fusion folder this instead relies on using Fusion masterprefs - which is way to override settings, through which we can customize the 'path map' locations for scripts and thus load them directly from OpenPype. --> Note: users that had launched the older integration would still have those original scripts in their scripts folders!
The OpenPype "menu" is now accessible as top-level OpenPype menu as opposed to hidden in Fusion's Comp scripts.
At the top of the OpenPype menu (the Qt floating menu) in Fusion it now shows the current context (where Avalon thinks it's operating in the current session) with regards to the current asset - since the Python scripts in Fusion run in a completely standalone process it can be non-trivial to find this out without a visual clue.

Global In/Out will now be considered as handles for your publish for all areas outside of the Current Time Range.
Added some tweaks to support Fusion 18+ (note that Fusion 18 supports multiple Py3 versions, in particular Python 3.3-3.10)
Added default settings for a Fusion 18 application entry
Added OCIO config setting which will set OCIO env var on Fusion launch if the setting is enabled (or maybe I should remove the enabled checkbox and allow to just skip if an empty OCIO config path was set in settings?
Fixed loader issue where it wouldn't align frames correctly if there were start handles.
Allow to minimze the OpenPype Menu window.
Fix Set Resolution in OpenPype menu
Fix Set Frame Range in OpenPype menu

Additional Context

Testing notes:

go through testing Fusion from the ground up - as if a new user

(cherry picked from commit 209511e)

BigRoy · 2022-02-20T21:27:34Z

This is currently a code merge of a few things which I haven't tested yet. I'm expecting to test by Tuesday the earliest.

antirotor · 2022-02-21T10:53:26Z

So, could this be tweaked a little bit to provide PySide2 and OTIO for Resolve? Just asking how much is it bound to Fusion logic.

BigRoy · 2022-02-21T13:41:33Z

So, could this be tweaked a little bit to provide PySide2 and OTIO for Resolve

This actually still doesn't provide PySide2 and OTIO out of the box - or at least PySide2 it doesn't. I'm not sure what'd be needed on OTIO end since I hadn't tested that at all.

The master prefs might be fusion specific - I'm not sure about that. Also, with regards to the top level menu in a .fu file - I'm not sure how well that transfers to Resolve unfortunately.

Can't provide much information here.

…s/fusion/scripts

…e scripts

BigRoy · 2022-02-22T22:29:06Z

Tweaked some more things for this PR and tested it in Fusion. Seemed to work fine.

Aside of these issues:

Save Prompt opens behind Work Files tool -> fixed with Work Files: Fix parenting of save prompt QMessageBox #2784
OpenPype logs are errors in the Fusion console -> separate issue Fusion: OpenPype Logging Handler always logs red errors messages ayon-fusion#5
Set Resolution in OpenPype menu does nothing - to be implemented
- should set: Comp settings > Frame Format -> Resolution
There's no button to set the "Current FPS"? And there's no "new scene" callback to enforce it for the current comp. So should there maybe be a Set FPS button like Set Resolution and Set Frame Range until callbacks are in place?
- should set: Comp Settings > Frame Format > Frame Rate

Not a direct issue, but settings we might want to set for the comp by default too:

Comp Settings > General > Frames Start From > Sequence (instead of start from one)

At the same time since the Loaders already do so for published files this might actually be "forcing too much" by default? Nonetheless it makes me think once we have new scene callback/default settings implemented we might want to just expose a user to apply custom prefs overrides in OP admin settings.

@jakubjezek001 any chance you could also take a look at the current state and let me know what feels off to you?

jakubjezek001

Hey @BigRoy for the update! I was testing and at the moment found following problems:

when some work has been done in one shot context and then in workfile want to open other shot context, a dialogue window (in red rectangle) is showing under the workfile window

I have to change FUSION16_PYTHON36_HOME environment key in prelaunch hook as it is not supported by app setting yet. Reversing it to PYTHON36 was fixing it for me for the test. https://github.com/pypeclub/OpenPype/blob/237ce7938dc04d163308cf34960433eac3132609/openpype/settings/defaults/system_settings/applications.json#L698
publishing created render node was working well
loading rendered image sequence or mov works but having an issue with correctly setting frameranges

BigRoy · 2022-02-24T15:39:13Z

when some work has been done in one shot context and then in workfile want to open other shot context, a dialogue window (in red rectangle) is showing under the workfile window

Correct - as mentioned that's fixed in #2784

I have to change FUSION16_PYTHON36_HOME environment key in prelaunch hook as it is not supported by app setting yet. Reversing it to PYTHON36 was fixing it for me for the test.

I set that in the Application environment - just like how it was set before for PYTHON36.

loading rendered image sequence or mov works but having an issue with correctly setting frameranges

What's the issue? :)

mkolar · 2022-02-24T15:56:13Z

Task linked: OP-2667 Fusion: set framerange from menu button

jakubjezek001 · 2022-02-24T16:03:01Z

openpype/hosts/fusion/deploy/fusion_shared.prefs

+ Paths = {
+  Map = {
+   ["OpenPype:"] = "$(OPENPYPE_FUSION)/deploy",
+   ["Reactor:"] = "$(REACTOR)",


Could not find it. Is there set somewhere in app environments?

Ah, REACTOR is only there because it's used by almost everyone working with Fusion in a more than average capacity. The unfortunate side effect of masterprefs is that it "locks" the settings to those values. So a user/studio couldn't set custom path maps for their studio unless they were to change the .prefs file.

REACTOR would be an environment variable set by the studio as to where they have that installed (if they use it). If they don't it's mostly disregarded by fusion because the pathmapping doesn't resolve to anything.

You'd set it in Admin Settings, like FUSION16_PYTHON36_HOME as in my screenshot here.

jakubjezek001 · 2022-02-24T16:12:55Z

What's the issue? :)

So I was testing it one more time and found out there is problem with the set_framerange. It is defining render range exluding handles and if publishing of the render node is done during those render range defined, it will render only range without handles.

Once it is loaded back to workfile, it is set to the first workfile frame and it seems to be wrong. I wonder if the render range could be ignored during publishing. The handles identified by those limits shown in image are cool and we are used to work with those in Nuke. User is interactivly shown what is in edit and what is handle.

It would be good to tel rendering plugin that it should render full range.

BigRoy · 2022-02-24T18:44:24Z

@jakubjezek001 Thanks for being so verbose about the issue - but somehow my mind is having a hard time grasping exactly what issue you're having with the handles. Any chance you could do a screen recording of the issue?

mkolar · 2022-03-03T10:34:41Z

I think what @jakubjezek001 is trying to say is that you are rendering frame range without handles, 1001-1005 in the example, however it should be rendering with handles included for consistency.

…on_v2 # Conflicts: # openpype/scripts/fusion_switch_shot.py

BigRoy · 2022-09-19T16:10:19Z

Have tweaked the addon to set OPENPYPE_LOG_NO_COLORS, tweaked the default fusion environment in applications defaults to match what is needed for current implementation to work, fixed the "Set Resolution" button in the OpenPype menu to do anything.

Currently there's no logic anywhere which sets the Comp's default aspect ratio, fps, etc. I feel like that would still be good to add.
There are no real working callbacks for Fusion that I've been able to get to work consistently which would also be able to quickly run against the python code because it'd each run a new python process as far as I am aware. But, that might be best as a separate issue to solve.

Ready for review!

+ fix import of host tools

…ng it unusable for these particular validations

BigRoy · 2022-09-20T13:08:18Z

@jakubjezek001 Any chance you're able to look into this PR quickly? :) I'm working on another Fusion integration tweak which might be quite big on top of this PR and I'd love to PR it separate.

It would have the OpenPype menu context try and auto-match with the currently active comp so that if you were to have multiple comps open at the same time from different assets that the UI would be able to change along with when you click into another comp. It'd be based on a timer (running e.g. every 2.5 second - since it runs in a separate process it doesn't trigger any slowdowns in Fusion and runs in 0.0009 seconds or anyway).

Actually thinking about that now that could technically be dangerous during publishing if some of the logic there would rely on the context to remain the same during the publishing instead of the user potentially clicking into another comp as he starts the the publish. Maybe instead it should highlight the asset name at the top of the menu with a different color to notify it's not matching - and maybe add a button to "refresh" or "sync" it again. Sounds like a good reason to keep that a separate PR already.

(cherry picked from commit c902d7b)

- UIs have pretty much no delays so no need to print

OpenPype manager/containers don't use it so it's redundant in the code base.

…stall + fix comment

…on_v2

jakubjezek001

Works perfect! Thanks you ;)

jakubjezek001 · 2022-09-21T11:10:35Z

Actually thinking about that now that could technically be dangerous during publishing if some of the logic there would rely on the context to remain the same during the publishing instead of the user potentially clicking into another comp as he starts the the publish. Maybe instead it should highlight the asset name at the top of the menu with a different color to notify it's not matching - and maybe add a button to "refresh" or "sync" it again. Sounds like a good reason to keep that a separate PR already.

I wonder if the context is collected only once at start of publishing and then it is not required anymore. Even Integrate is taking Context data from collected, right? @iLLiCiTiT

iLLiCiTiT · 2022-09-21T11:39:33Z

wonder if the context is collected only once at start of publishing and then it is not required anymore. Even Integrate is taking Context data from collected, right? @iLLiCiTiT

It is, but there is a lot of plugins that are still using legacy_io or os.environ directly and it's hard to identify if we can "just switch" them because I'm not sure when context is filled during farm publishing.

Definetely not issue for this PR :)

BigRoy · 2022-09-21T12:45:37Z

Definetely not issue for this PR :)

Yes - different issue, different PR.

@iLLiCiTiT any chance this PR could get your approval for a merge?

BigRoy and others added 2 commits February 20, 2022 22:02

Pull Fusion integration from colorbleed

e8d6f1d

fusion: adding reset resolution

e72c768

(cherry picked from commit 209511e)

BigRoy added type: enhancement Enhancements to existing functionality host: Fusion labels Feb 20, 2022

BigRoy requested review from jakubjezek001 and iLLiCiTiT February 20, 2022 21:18

BigRoy self-assigned this Feb 20, 2022

BigRoy mentioned this pull request Feb 20, 2022

Fusion: migrate colorbleed fork code #2752

Closed

BigRoy added 3 commits February 20, 2022 22:22

Fix hound issues

1b40d51

Avoid assigning a lambda expression

43be200

Fix double "render" family

860f159

BigRoy linked an issue Feb 20, 2022 that may be closed by this pull request

Fusion: set framerange from menu button #2742

Closed

BigRoy added 5 commits February 22, 2022 20:58

Fusion: Add support for open last workfile

cdca18e

Fix typo + wrong label

4e614c8

Remove duplicate script that has more recent version in openpype/host…

959aa2a

…s/fusion/scripts

Move Comp scripts to an OpenPype submenu to clarify those are OpenPyp…

51ef4ce

…e scripts

Fix on_pyblish_instance_toggled arguments

2f9eb8f

BigRoy mentioned this pull request Feb 23, 2022

Fusion: Tweak integration implementation BigRoy/OpenPype#2

Closed

jakubjezek001 suggested changes Feb 24, 2022

View reviewed changes

jakubjezek001 reviewed Feb 24, 2022

View reviewed changes

Merge remote-tracking branch 'upstream/develop' into fusion_integrati…

4c81d1d

…on_v2 # Conflicts: # openpype/scripts/fusion_switch_shot.py

BigRoy added 2 commits September 19, 2022 18:06

Set OPENPYPE_LOG_NO_COLORS in addon

863265f

Update defaults for Fusion environment

df330e1

BigRoy added 11 commits September 19, 2022 18:12

Tweak docstrings

c725c6a

Store link to menu so we can get access to it elsewhere

1f035a1

Add after open callback to show popup about outdated containers

23b6a35

Move get_current_comp and comp_lock_and_undo_chunk to lib

30ee358

+ fix import of host tools

Remove unused imports

9dda39a

Add validate comp prefs on scene before save and after scene open

15c3b06

Don't error if "show" is clicked but comp is closed already

fb940c5

Remove double space

1013a29

Remove before save callback since it runs BEFORE the task change maki…

2df5d87

…ng it unusable for these particular validations

Add a pop-up about invalid comp configuration

4c884ed

Shush hound

794e8a9

BigRoy added 9 commits September 20, 2022 19:39

Set OpenPype icon for menu

64ef00b

(cherry picked from commit c902d7b)

Remove redundant Spacer widget and use QVBoxLayout.addSpacing

a8d9047

Remove "Clicked {button}" print statements

1ce7e69

- UIs have pretty much no delays so no need to print

Get current comp once and as early as possible

1561032

Remove get_additional_data

6bcb9dd

OpenPype manager/containers don't use it so it's redundant in the code base.

Remove redundant saying "installed" even though it's midway during in…

3c134ec

…stall + fix comment

Cleanup Create EXR saver logic

0b525fa

Clean up docstring

b62d127

Merge remote-tracking branch 'upstream/develop' into fusion_integrati…

604940c

…on_v2

jakubjezek001 approved these changes Sep 21, 2022

View reviewed changes

BigRoy mentioned this pull request Sep 21, 2022

Refactor Fusion to New OpenPype Publisher BigRoy/OpenPype#8

Closed

iLLiCiTiT merged commit 70c24ba into ynput:develop Sep 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fusion: Tweak Fusion integration #2769

Fusion: Tweak Fusion integration #2769

BigRoy commented Feb 20, 2022 •

edited

Loading

BigRoy commented Feb 20, 2022

antirotor commented Feb 21, 2022

BigRoy commented Feb 21, 2022

BigRoy commented Feb 22, 2022

jakubjezek001 left a comment •

edited

Loading

BigRoy commented Feb 24, 2022

mkolar commented Feb 24, 2022

jakubjezek001 Feb 24, 2022

BigRoy Feb 24, 2022

jakubjezek001 commented Feb 24, 2022

BigRoy commented Feb 24, 2022

mkolar commented Mar 3, 2022

BigRoy commented Sep 19, 2022 •

edited

Loading

BigRoy commented Sep 20, 2022 •

edited

Loading

jakubjezek001 left a comment

jakubjezek001 commented Sep 21, 2022

iLLiCiTiT commented Sep 21, 2022 •

edited

Loading

BigRoy commented Sep 21, 2022

Fusion: Tweak Fusion integration #2769

Fusion: Tweak Fusion integration #2769

Conversation

BigRoy commented Feb 20, 2022 • edited Loading

Brief description

Description

Additional Context

Testing notes:

BigRoy commented Feb 20, 2022

antirotor commented Feb 21, 2022

BigRoy commented Feb 21, 2022

BigRoy commented Feb 22, 2022

jakubjezek001 left a comment • edited Loading

Choose a reason for hiding this comment

BigRoy commented Feb 24, 2022

mkolar commented Feb 24, 2022

jakubjezek001 Feb 24, 2022

Choose a reason for hiding this comment

BigRoy Feb 24, 2022

Choose a reason for hiding this comment

jakubjezek001 commented Feb 24, 2022

BigRoy commented Feb 24, 2022

mkolar commented Mar 3, 2022

BigRoy commented Sep 19, 2022 • edited Loading

BigRoy commented Sep 20, 2022 • edited Loading

jakubjezek001 left a comment

Choose a reason for hiding this comment

jakubjezek001 commented Sep 21, 2022

iLLiCiTiT commented Sep 21, 2022 • edited Loading

BigRoy commented Sep 21, 2022

BigRoy commented Feb 20, 2022 •

edited

Loading

jakubjezek001 left a comment •

edited

Loading

BigRoy commented Sep 19, 2022 •

edited

Loading

BigRoy commented Sep 20, 2022 •

edited

Loading

iLLiCiTiT commented Sep 21, 2022 •

edited

Loading