This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Ftrack: Don't force ftrackapp endpoint #4411
Merged
+38
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: OP-4773 private ftrack url is NOT ftrackapp.com |
|
do you have an idea how to test this one? |
64qam
approved these changes
Feb 2, 2023
iLLiCiTiT
deleted the
bugfix/OP-4773_private-ftrack-url-is-NOT-ftrackappcom
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Auto-fill of ftrack url don't break custom urls. Custom urls couldn't be used as
ftrackapp.comis added if is not in the url.Description
The code was changed in a way that auto-fill is still supported but before
ftrackappis added it will try to use url as is. If the connection works as is it is used.Additional info
Can't test it as I wasn't able run ftrack server locally and couldn't run redirect proxy either.
Testing notes:
ftrackappin url