3dsmax: Use custom modifiers to hold instance members #4931
Conversation
…-use-custom-modifier-attributes
antirotor
added
type: enhancement
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
"pyflakes" failed during execution due to "'FlakesChecker' object has no attr...
"pyflakes" failed during execution due to "'FlakesChecker' object has no attribute 'NAMEDEXPR'" Run flake8 with greater verbosity to see more details
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
"pyflakes" failed during execution due to "'FlakesChecker' object has no attr...
"pyflakes" failed during execution due to "'FlakesChecker' object has no attribute 'NAMEDEXPR'" Run flake8 with greater verbosity to see more details
|
For some reason Hound is heavily fighting with the walrus operator |
|
Removing instance errors out. Using the original removing instance code may resolve this as removing container node in modifier meaning unparenting the added objects from the container |
|
A question: should the creators also be refratored? |
|
I have just started with testing this PR so Im creating list for testing different instances: Test has been made for Publish / Load of
|
|
Speaking of first tests I did for Maybe its not an issue and I can imagine this will occur for any other families/ instances too. Take it more like a note or food for thought.
|
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
"pyflakes" failed during execution due to "'FlakesChecker' object has no attr...
"pyflakes" failed during execution due to "'FlakesChecker' object has no attribute 'NAMEDEXPR'" Run flake8 with greater verbosity to see more details
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
"pyflakes" failed during execution due to "'FlakesChecker' object has no attr...
"pyflakes" failed during execution due to "'FlakesChecker' object has no attribute 'NAMEDEXPR'" Run flake8 with greater verbosity to see more details
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
"pyflakes" failed during execution due to "'FlakesChecker' object has no attr...
"pyflakes" failed during execution due to "'FlakesChecker' object has no attribute 'NAMEDEXPR'" Run flake8 with greater verbosity to see more details
|
@antirotor i have updated the PR for removing instance through the OP Parameter, it should be working now. Also I edited the string for the new collector to ease the confusion from |
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
"pyflakes" failed during execution due to "'FlakesChecker' object has no attr...
"pyflakes" failed during execution due to "'FlakesChecker' object has no attribute 'NAMEDEXPR'" Run flake8 with greater verbosity to see more details
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
"pyflakes" failed during execution due to "'FlakesChecker' object has no attr...
"pyflakes" failed during execution due to "'FlakesChecker' object has no attribute 'NAMEDEXPR'" Run flake8 with greater verbosity to see more details
|
It works! I've removed two debug prints, and when approved by @LiborBatek , we can finally merge it. |
…ttps://github.com/ynput/OpenPype into enhancement/3dsmax-use-custom-modifier-attributes
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
"pyflakes" failed during execution due to "'FlakesChecker' object has no attr...
"pyflakes" failed during execution due to "'FlakesChecker' object has no attribute 'NAMEDEXPR'" Run flake8 with greater verbosity to see more details
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
"pyflakes" failed during execution due to "'FlakesChecker' object has no attr...
"pyflakes" failed during execution due to "'FlakesChecker' object has no attribute 'NAMEDEXPR'" Run flake8 with greater verbosity to see more details
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
"pyflakes" failed during execution due to "'FlakesChecker' object has no attr...
"pyflakes" failed during execution due to "'FlakesChecker' object has no attribute 'NAMEDEXPR'" Run flake8 with greater verbosity to see more details
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
"pyflakes" failed during execution due to "'FlakesChecker' object has no attr...
"pyflakes" failed during execution due to "'FlakesChecker' object has no attribute 'NAMEDEXPR'" Run flake8 with greater verbosity to see more details
Co-authored-by: Kayla Man <64118225+moonyuet@users.noreply.github.com>
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
"pyflakes" failed during execution due to "'FlakesChecker' object has no attr...
"pyflakes" failed during execution due to "'FlakesChecker' object has no attribute 'NAMEDEXPR'" Run flake8 with greater verbosity to see more details
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
"pyflakes" failed during execution due to "'FlakesChecker' object has no attr...
"pyflakes" failed during execution due to "'FlakesChecker' object has no attribute 'NAMEDEXPR'" Run flake8 with greater verbosity to see more details
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
"pyflakes" failed during execution due to "'FlakesChecker' object has no attr...
"pyflakes" failed during execution due to "'FlakesChecker' object has no attribute 'NAMEDEXPR'" Run flake8 with greater verbosity to see more details
Changelog Description
Moving logic to handle members of publishing instance from children/parent relationship on Container to tracking via custom attribute on modifier. This eliminates limitations where you couldn't have one node multiple times under one Container and because it stores those relationships as weak references, they are easily transferable even when original nodes are renamed.
Additional info
Because of this change, all publishing plugins were affected. Now there is a collector plugin getting all nodes referenced by instance node and storing them on
instance.data["members"]for easy access. This is also changing type case to align it more with 3dsmax python API and few style changes.Testing notes:
Publishing of all types should work as before. In particular the tyFlow publishing needs testing because there was some refactoring involved.
[cbID:OP-5754]