This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
CI: WPS linting instead of Hound #4934
Closed
+238
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Beyond the scope of this PR, but I was wondering if it would be beneficial to use |
so, the trouble with ruff is that it doesn't support posting review comments on GH as far as I know, the errors show only in process details and that is somewhat lost. |
|
In that case, how about we get on with it and merge this? |
|
closed in favour of rebased #5072 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Because Hound currently used to lint the code on GH ships with really old flake8 support, it fails miserably on any newer Python syntax. This PR is adding WPS linter to GitHub workflows that should step in.
Additional info
WPS linter suit is checking now even docstrings and it seems much more stricter than Hound, so it is a matter of discussion to set its limits.
Testing notes:
Try this configuration file with your PRs and see its feedback. It should post code comments the same way as Hound does.