Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Enhancement/publisher: Remove "hit play to continue" label on continue #5029

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented May 24, 2023

Changelog Description

Remove "hit play to continue" message on continue so that it doesn't show anymore when play was clicked.

Additional info

Resolve issue described here

Testing notes:

  1. Click validate
  2. Wait for it to finish validation successfully
  3. Click publish
  4. Now while it is publishing it will be expanded (that's correct) and it should not show the subtitle (second line in the message) Hit publish (play button) to continue) because it's currently playing/publishing.

This can also be reproduced by:

  1. Click validate
  2. Stop/Pause the validation
  3. Continue the validation or publishing
  4. Now while it is publishing it will be expanded (that's correct) and it should not show the subtitle (second line in the message) Hit publish (play button) to continue) because it's currently playing/publishing.

@BigRoy BigRoy added type: enhancement Enhancements to existing functionality community contribution tool: Publisher labels May 24, 2023
@BigRoy BigRoy requested a review from iLLiCiTiT May 24, 2023 18:24
@ynbot ynbot added the size/XS Denotes a PR changes 0-99 lines, ignoring general files label May 24, 2023
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iLLiCiTiT iLLiCiTiT merged commit 41ae41d into ynput:develop May 25, 2023
@ynbot ynbot added this to the next-patch milestone May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community contribution size/XS Denotes a PR changes 0-99 lines, ignoring general files tool: Publisher type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants