This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
CreatePlugin: Get next version helper #5242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: OP-6324 get next version in creators |
ynbot
added
type: feature
BigRoy
reviewed
Jul 5, 2023
jakubjezek001
approved these changes
Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Implemented helper functions to get next available versions for create instances.
Additional info
The helper functions are doing what they can do with available data on instances to find next possible available version for an instance. I would be scared to use the value for publishing as publishing may have different requirements in different cases so it should be always optional. This is a quick PR to unblock custom staging directory PR.
Other possible usages need more brainstorm. About how to use it, before using it everywhere. e.g. to show the version in UI (and possibly change it?) would mean that the value must be in instance data.
Testing notes:
Since the code is not used, it must be faked.
self.get_next_versions_for_instancesoncollect_instancesand oncreate.