Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Review: Multilayer specification for ffmpeg #5613

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Extract review is specifying layer name when exr is multilayer.

Additional info

This issue was discovered with renders from blender where output exr had channels ['Main.AOV.R', 'Main.AOV.G', 'Main.AOV.B', 'Main.AOV.A', 'Main.Combined.R', 'Main.Combined.G', 'Main.Combined.B', 'Main.Combined.A', 'Main.Normal.X', 'Main.Normal.Y', 'Main.Normal.Z', 'Main.Test.X'] which failed in ffmpeg.

Testing notes:

  1. First of all, any other current exr processing should still work (e.g. multipart exrs from maya)
  2. Render from blender (testing for @simonebarbieri )

@ynbot ynbot added type: bug Something isn't working size/S Denotes a PR changes 100-499 lines, ignoring general files labels Sep 13, 2023
openpype/lib/transcoding.py Outdated Show resolved Hide resolved
openpype/lib/transcoding.py Show resolved Hide resolved
openpype/plugins/publish/extract_review.py Show resolved Hide resolved
openpype/lib/transcoding.py Outdated Show resolved Hide resolved
@kalisp kalisp self-requested a review September 14, 2023 09:24
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to break anything in automatic tests, but I don't think that tests would be actually testing this.

@iLLiCiTiT
Copy link
Member Author

We also want to add option to be able define preferred layer names to be used for review, but that's for another PR.

@iLLiCiTiT iLLiCiTiT merged commit 93fb76f into develop Sep 14, 2023
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/ffmpeg-conversion-check-for-rgb branch September 14, 2023 11:55
@ynbot ynbot added this to the next-patch milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR changes 100-499 lines, ignoring general files type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants