Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Fussion: added support for Fusion 17 #5614

Merged
merged 12 commits into from
Sep 15, 2023
Merged

Fussion: added support for Fusion 17 #5614

merged 12 commits into from
Sep 15, 2023

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Sep 13, 2023 •
edited
Loading

Changelog Description

Fusion 17 still uses Python 3.6 which causes issues with some our delivered libraries. Vendorized necessary set for Python 3.6

Additional Information

It should be tested in Fusion 18 too, but it is explicitly adding older libraries for versions lower than 18.

Testing notes:

  1. start Fusion 17
  2. open Openpype Menu - should show up
  3. (you could check console output in View > Console

@ynbot
Copy link
Contributor

ynbot commented Sep 13, 2023

Task linked: OP-6780 Fusion 17 python 3.6 compatibility

@ynbot ynbot added type: bug Something isn't working size/XXL Denotes a PR changes 2500+ lines, ignoring general files host: Fusion labels Sep 13, 2023
@kalisp kalisp added the sponsored Client endorsed or requested label Sep 14, 2023
kalisp and others added 9 commits September 14, 2023 13:46
@kalisp @BigRoy
Update openpype/hosts/fusion/addon.py
cc2eba8 
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@kalisp
OP-6780 - add vendorized libraries even before menu creation
5250ab8 
This should help when version of Fusion > 17, but it is still using 3.6
@kalisp
OP-6780 - added todo message to remember to remove this
a56936e
@kalisp
OP-6780 - move injection of PYTHONPATH much sooner
12e1481 
At previous position it was too late.
@kalisp
OP-6780 - better capture of broken imports
313ffb3
@kalisp
OP-6780 - SyntaxError is thrown only if directly importing
fb40b3f
@kalisp
OP-6780 - remove unnecessary imports
6a46d4e 
Only urllib3 and attrs are actually needed
@kalisp
OP-6780 - vendorize even directly in Fusion if Python < 3.7
6d5a5fd
@kalisp
OP-6780 - remove update of PYTHONPATH in addon
8faf40c 
More important and required is check directly in interpreter in Fusion, it doesn't make sense to pollute addon and have it on two places. It might get removed altogether in next-minor.
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with all combinations and with app strings as Fusion17/Fusion18

  • Fusion17 with Python 3.6
  • Fusion 18 with Python 3.6
  • Fusion 18 with Python 3.9

@kalisp kalisp merged commit 67abbaa into develop Sep 15, 2023
@kalisp kalisp deleted the bugfix/OP-6780_Fusion-17-python-36-compatibility branch September 15, 2023 09:02
@ynbot ynbot added this to the next-patch milestone Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BigRoy BigRoy BigRoy left review comments

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@m-u-r-p-h-y m-u-r-p-h-y

Labels
host: Fusion size/XXL Denotes a PR changes 2500+ lines, ignoring general files sponsored Client endorsed or requested type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
3.16.7
Development

Successfully merging this pull request may close these issues.
4 participants
@kalisp @ynbot @m-u-r-p-h-y @BigRoy