Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Add Maya 2024 and remove pre 2022. #5674

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Maya: Add Maya 2024 and remove pre 2022. #5674

merged 2 commits into from
Oct 17, 2023
+28 −108

Conversation

tokejepsen
Copy link
Member

Changelog Description

Adding Maya 2024 as default application variant.

Removing Maya 2020 and older, as these are not supported anymore.

Testing notes:

  1. Launch settings with a new database and validate only Maya 2024-2022 is present.

Split from #5644

@tokejepsen tokejepsen added the sponsored Client endorsed or requested label Oct 2, 2023
@ynbot ynbot added type: enhancement Enhancements to existing functionality size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Oct 2, 2023
@ynbot ynbot removed the host: Maya label Oct 2, 2023
BigRoy
BigRoy approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but looks good to me ❤️

@BigRoy
Copy link
Collaborator

BigRoy commented Oct 2, 2023

Actually - is this missing an update to AYON settings for Maya?

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Oct 2, 2023 •
edited
Loading

Please add AYON settings changes too.

Actually - is this missing an update to AYON settings for Maya?

Yes, please.

BigRoy
BigRoy suggested changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated - this should also update AYON defaults.
Sorry for commenting the same thing - I had to place a comment to change my approval status

@tokejepsen tokejepsen requested a review from BigRoy October 3, 2023 07:49
BigRoy
BigRoy approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it - but code looks good. Probably best to check against new deployment of Ayon and OpenPype I suppose? Probably for @LiborBatek?

@ynbot ynbot removed the host: Maya label Oct 5, 2023
iLLiCiTiT
iLLiCiTiT approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look ok. Someone has to validate if we should limit the maya versions to this set. @m-u-r-p-h-y ?

@antirotor
Copy link
Member

Code changes look ok. Someone has to validate if we should limit the maya versions to this set. @m-u-r-p-h-y ?

I don't think we support Maya 2018 and with Maya 2020 I would be surprised if there are no issues. Anyway, there's no problem to define them locally if needed

@m-u-r-p-h-y
Copy link
Member

m-u-r-p-h-y commented Oct 5, 2023 •
edited
Loading

I agree to have only M2022 and up

if we are touching the defaults I would like to unify the paths for other platforms. We have linux paths defined somewhere but no Mac (not sure what is the default path on MAc though)

something like /Applications/Autodesk/maya2022/Maya.app/Contents/bin/maya ?

@tokejepsen
Copy link
Member Author

if we are touching the defaults I would like to unify the paths for other platforms. We have linux paths defined somewhere but no Mac (not sure what is the default path on MAc though)

Could this be a different PR for another time?

@mkolar
Copy link
Member

mkolar commented Oct 17, 2023

I agree we can tweak the paths in another PR. let's merge this, so it's not festering.

@mkolar mkolar merged commit bcb9ee1 into ynput:develop Oct 17, 2023
17 of 18 checks passed
@ynbot ynbot added this to the next-patch milestone Oct 17, 2023
@tokejepsen tokejepsen deleted the enhancement/maya_supported_versions branch October 17, 2023 06:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@antirotor antirotor antirotor approved these changes

@BigRoy BigRoy BigRoy approved these changes

@Minkiu Minkiu Minkiu approved these changes

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

@m-u-r-p-h-y m-u-r-p-h-y Awaiting requested review from m-u-r-p-h-y

Assignees

@m-u-r-p-h-y m-u-r-p-h-y

@LiborBatek LiborBatek

Labels
size/XS Denotes a PR changes 0-99 lines, ignoring general files sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality
Projects
PR reviewing
Archived in project
Milestone
3.17.3
Development

Successfully merging this pull request may close these issues.
9 participants
@tokejepsen @BigRoy @iLLiCiTiT @antirotor @m-u-r-p-h-y @mkolar @Minkiu @ynbot @LiborBatek