Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Tweak logging for Nuke for artist facing reports #5763

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Enhancement: Tweak logging for Nuke for artist facing reports #5763

merged 3 commits into from
Oct 13, 2023
+52 −60

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Oct 13, 2023

Changelog Description

Tweak logs that are not artist-facing to debug level + in some cases clarify what the logged value is.

Additional info

Note that I don't use Nuke, so someone else would need to test how well the reports now end up in Nuke.

Testing notes:

  1. Publish lots of different stuff from Nuke, like models, renders, cameras, etc.

The Publish Reports should not contain technical logs - but should be limited only to information an artist cares about after a publish.

@BigRoy BigRoy added type: enhancement Enhancements to existing functionality host: Nuke community contribution labels Oct 13, 2023
@ynbot ynbot added the size/S Denotes a PR changes 100-499 lines, ignoring general files label Oct 13, 2023
@jakubjezek001 jakubjezek001 self-assigned this Oct 13, 2023
jakubjezek001
jakubjezek001 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as before and logs looks prettier when not in debug mode!

@jakubjezek001 jakubjezek001 merged commit b5189a7 into ynput:develop Oct 13, 2023
1 check passed
@ynbot ynbot added this to the next-patch milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

@mkolar mkolar Awaiting requested review from mkolar

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

Assignees

@jakubjezek001 jakubjezek001

Labels
community contribution host: Nuke size/S Denotes a PR changes 100-499 lines, ignoring general files type: enhancement Enhancements to existing functionality
Projects
PR reviewing
Archived in project
Milestone
3.17.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BigRoy @jakubjezek001 @ynbot