Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Max: Implement Validator for Properties/Attributes Value Check #5824

Merged
merged 16 commits into from
Nov 6, 2023

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Oct 26, 2023

Changelog Description

Add optional validator which can check if the property attributes are valid in Max

Additional info

Paragraphs of text giving context of additional technical information or code examples.

Testing notes:

  1. Launch Max via launcher
  2. Enable Validate Attributes in Settings
  3. Put the relevant attributes into the "Attributes" dict. if you want to check if renderers.current.separateAovFiles=true or renderers.current.MotionBlurShutterAngle=160.5 etc..
{
    "renderers.current": {
        "separateAovFiles": true,
        "MotionBlurShutterAngle": 160.5,
        "PrimaryGIEngine": "#RS_GIENGINE_BRUTE_FORCE",
        "OCIOViewName": "ACES 1.0 SDR-video"
    }
}

image

  1. Create Instance
  2. Publish
  3. If it doesn't pass the validation, please check the message to see if it can be fixed by repair action.
  4. If you receive Unknown Property Values :{your input attribute}, you need to make sure this attribute exists in maxscript as the property value
  5. If the message in 7 doesn't exists, you can use the repair action to repair the setting in 3dsMax.

@ynbot
Copy link
Contributor

ynbot commented Oct 26, 2023

Task linked: OP-7071 Validate Attributes

1 similar comment
@ynbot
Copy link
Contributor

ynbot commented Oct 26, 2023

Task linked: OP-7071 Validate Attributes

@ynbot ynbot added host: 3dsmax Autodesk 3dsmax size/S Denotes a PR changes 100-499 lines, ignoring general files type: enhancement Enhancements to existing functionality labels Oct 26, 2023
@moonyuet moonyuet marked this pull request as ready for review October 30, 2023 13:17
@moonyuet moonyuet marked this pull request as draft October 31, 2023 05:08
@moonyuet moonyuet marked this pull request as ready for review October 31, 2023 12:58
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made tests with Rshift render and all seems working fine.

When criteria not met Validation fails and Repair action shows up:
image

After that all set by Repair so Publish being possible due to correct settings and validation passed.

image

@LiborBatek
Copy link
Member

Note: When unknown entry the Validation fail but wont give nice human readible error but user need to go to Detailed report to seek for particular issue.

Ideally this could be shown the same way as with other known attributes validation...

@LiborBatek
Copy link
Member

I have succesfully tested both with RShift and Arnold attribs and all working nicely!

@moonyuet moonyuet requested a review from BigRoy November 6, 2023 06:20
@mkolar mkolar merged commit 20eaa0b into develop Nov 6, 2023
7 checks passed
@ynbot ynbot added this to the next-patch milestone Nov 6, 2023
@mkolar mkolar deleted the enhancement/OP-7071_Validate-Attributes branch January 25, 2024 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: 3dsmax Autodesk 3dsmax size/S Denotes a PR changes 100-499 lines, ignoring general files type: documentation type: enhancement Enhancements to existing functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants