Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traypublisher: editorial avoid audio tracks processing #6038

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Traypublisher: editorial avoid audio tracks processing #6038

merged 7 commits into from
Feb 7, 2024

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Dec 11, 2023 •
edited
Loading

Changelog Description

Avoiding audio tracks from EDL editorial publishing.

Additional info

  • Refactored the code to filter tracks based on their kind being "Video"
  • Added a comment to clarify the purpose of media_data variable
  • Added a comment to explain setting track name
  • Removed an unnecessary blank line

TODO:

  • Fix: missing otioReference on video clips once audio tracks are avoided

Testing notes:

  1. Test it on Simple Editorial workflow in Traypublisher
  2. make sure that each clip is having AA/V mark in tracks column.

@jakubjezek001
Refactor create_editorial.py for better track handling
6f21911 
- Refactored the code to filter tracks based on their kind being "Video"
- Added a comment to clarify the purpose of media_data variable
- Added a comment to explain setting track name
- Removed an unnecessary blank line
@jakubjezek001
improving plugin label so it is easier to read
fc179be
@ynbot ynbot added type: bug Something isn't working host: TrayPublisher size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Dec 11, 2023
@iLLiCiTiT iLLiCiTiT changed the title Traypublisher: editoiral avoid audio tracks processing Traypublisher: editorial avoid audio tracks processing Dec 11, 2023
iLLiCiTiT
iLLiCiTiT approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look reasonable.

@jakubjezek001 jakubjezek001 marked this pull request as draft December 20, 2023 15:58
iLLiCiTiT
iLLiCiTiT approved these changes Dec 21, 2023 •
edited
Loading
View reviewed changes
@jakubjezek001
Merge branch 'develop' into bugfix/traypublish-editorial-avoid-audio-…
acc2f9f 
…track
@jakubjezek001
Merge branch 'develop' into bugfix/traypublish-editorial-avoid-audio-…
3acd53e 
…track
@jakubjezek001
Refactor code for creating and publishing editorial clips
0bbe25f 
- renaming variable to specify correctly value type
- Added a condition in `collect_shot_instances.py` to check if the parent kind is "Video" before collecting shot instances.
@jakubjezek001 jakubjezek001 marked this pull request as ready for review January 29, 2024 16:01
@jakubjezek001
Copy link
Member Author

Task linked: OP-7579 Editorial: fix collect editorial resources

@iLLiCiTiT iLLiCiTiT merged commit 0c37c0e into develop Feb 7, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/traypublish-editorial-avoid-audio-track branch February 7, 2024 10:20
@ynbot ynbot added this to the next-patch milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

@64qam 64qam Awaiting requested review from 64qam

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

Assignees

@antirotor antirotor

Labels
host: TrayPublisher size/XS Denotes a PR changes 0-99 lines, ignoring general files target: AYON target: OpenPype type: bug Something isn't working
Projects
PR reviewing
Archived in project
Milestone
3.18.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jakubjezek001 @iLLiCiTiT @mkolar @antirotor @ynbot